PR_26179_OWNER_008-update-path-governance-final#243
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6831a2c552
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Transition rule: | ||
|
|
||
| - Existing top-level `src/advanced/`, `src/api/`, `src/dev-runtime/`, `src/engine/`, `src/shared/`, and `src/tools/` directories are legacy transition buckets until explicit migration PRs move them. | ||
| - Do not add new top-level `src/` layer names outside `src/web/`, `src/api-runtime/`, or `src/runtime/` without OWNER approval. |
There was a problem hiding this comment.
This new rule is not covered by the canonical-structure validation that the PR reports as passing: dev/scripts/validate-canonical-repository-structure.mjs still only audits src/engine/ and still reports the expected layout as src/engine/{feature-name}/, so a future file like src/foo/new.js or src/api/new.js passes with no finding despite being disallowed here. Please update the guardrail alongside the final path standard so CI actually blocks new unapproved top-level src/ layers.
Useful? React with 👍 / 👎.
| R dev/docs_build/dev/reports/PR_26175_DELTA_005_Runtime_Technical_Debt_Cleanup-branch-validation.md -> dev/reports/PR_26175_DELTA_005_Runtime_Technical_Debt_Cleanup-branch-validation.md | ||
| R dev/docs_build/dev/reports/PR_26175_DELTA_005_Runtime_Technical_Debt_Cleanup-manual-validation-notes.md -> dev/reports/PR_26175_DELTA_005_Runtime_Technical_Debt_Cleanup-manual-validation-notes.md | ||
| R dev/docs_build/dev/reports/PR_26175_DELTA_005_Runtime_Technical_Debt_Cleanup-requirement-checklist.md -> dev/reports/PR_26175_DELTA_005_Runtime_Technical_Debt_Cleanup-requirement-checklist.md | ||
| R dev/docs_build/dev/reports/PR_26175_DELTA_005_Runtime_Technical_Debt_Cleanup-validation.md -> dev/reports/PR_26175_DELTA_005_Runtime_Technical_Debt_Cleanup-validation.md | ||
| R dev/docs_build/dev/reports/PR_26175_DELTA_005_Runtime_Technical_Debt_Cleanup.md -> dev/reports/PR_26175_DELTA_005_Runtime_Technical_Debt_Cleanup.md | ||
| R dev/docs_build/dev/reports/PR_26175_DELTA_006-page-service-test-lanes-branch-validation.md -> dev/reports/PR_26175_DELTA_006-page-ser |
There was a problem hiding this comment.
In the final commit, git diff --name-status c010aeb9^ c010aeb9 includes README.md, dev/README.md, and multiple ProjectInstructions files, but this required changed-files artifact lists only the workflow and PR report files, and codex_review.diff likewise omits those diff headers. In review/APPLY workflows that rely on these artifacts, the committed governance and README changes are hidden, so regenerate the artifacts after all scoped changes are included.
Useful? React with 👍 / 👎.
| - `dev/project-instructions/` is deprecated reference only when retained; it must point to `dev/docs_build/dev/ProjectInstructions/`. | ||
| - Root `docs_build/`, root `archive/`, and root `project-instructions/` are not active workspace locations after the governance workspace move. | ||
| - Root `docs_build/`, root `tests/`, root `archive/`, root `tmp/`, and root `project-instructions/` are not active workspace locations after the restructure. | ||
| - Root `tmp/` may remain ignored as legacy local scratch only; required Codex ZIPs and generated temporary artifacts belong under `dev/workspace/artifacts/tmp/`. |
There was a problem hiding this comment.
For BUILD work in this repo, the tracked AGENTS.md packaging section still instructs agents to write delta ZIPs to <project folder>/tmp/<TASK_NAME>_delta.zip, but this new final standard makes root tmp/ legacy-only and requires ZIPs under dev/workspace/artifacts/tmp/. In Codex/APPLY flows that read AGENTS first, agents can keep producing the root-level ZIP while the new governance and reports look for the dev-workspace ZIP, so update the authoritative agent instruction or make this line match it.
Useful? React with 👍 / 👎.
Owner-approved restructure stack closeout.
…date-path-governance-final
ToolboxAid
changed the base branch from
PR_26179_OWNER_007-move-reports-artifacts
to
main
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d581b010dd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - account/ | ||
| - admin/ | ||
| - legal/ | ||
| - assets/ |
There was a problem hiding this comment.
This canonical root list omits several tracked public page roots that already exist in this commit (community/, company/, learn/, marketplace/, memberships/, and owner/, each with HTML entrypoints). Because the same document says new development follows the canonical structure, future governance/cleanup work using this list as the source of truth can incorrectly treat those current product sections as non-canonical even though this PR neither moves nor deprecates them; include them here or explicitly list them as legacy exceptions.
Useful? React with 👍 / 👎.
| Finalize path governance after the dev workspace restructure chain and correct the PR #243 GitHub Actions platform-validation script path after the root `scripts/` directory moved to `dev/scripts/`. | ||
|
|
||
| ## Changes | ||
|
|
There was a problem hiding this comment.
In this commit, git diff --name-status 2c90ad0b^ 2c90ad0b has no .github/workflows/platform-validation.yml entry; the actual non-report changes are the README and Project Instructions governance files. Since this report is the PR's validation evidence, describing the change as only a workflow path correction can let APPLY/reviewers miss the path-governance changes that still need validation, so restore the report/checklist to cover the final governance delta rather than a non-existent workflow diff.
Useful? React with 👍 / 👎.
2 participants
PR_26179_OWNER_008-update-path-governance-final
Updated: 2026-06-27T20:36:34.395Z
Branch: PR_26179_OWNER_008-update-path-governance-final
ZIP: dev/workspace/artifacts/tmp/PR_26179_OWNER_008-update-path-governance-final_delta.zip
Purpose
Finalize path governance after the dev workspace restructure chain and correct the PR #243 GitHub Actions platform-validation script path after the root
scripts/directory moved todev/scripts/.Changes
.github/workflows/platform-validation.ymlfromnode ./scripts/run-platform-validation-suite.mjstonode ./dev/scripts/run-platform-validation-suite.mjs../scripts/paths.Validation Summary