Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 68 additions & 2 deletions assets/theme-v2/css/tables.css
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,67 @@ td {
color: var(--text)
}

.idea-board-table-caption {
position: relative;
z-index: var(--z-index-sm);
display: flex;
align-items: center;
justify-content: space-between;
gap: var(--space-10);
padding: var(--space-10);
font-weight: var(--font-weight-heavy)
}

.idea-board-show-filter {
position: relative;
z-index: var(--z-index-md);
color: var(--text);
font-size: var(--font-size-xs);
font-weight: var(--font-weight-bold)
}

.idea-board-show-filter summary {
display: inline-flex;
align-items: center;
min-height: var(--space-28);
padding: var(--space-3) var(--space-10);
border: var(--border-standard);
border-radius: var(--radius-md);
background: var(--panel-soft);
cursor: pointer;
list-style: none
}

.idea-board-show-filter summary::-webkit-details-marker {
display: none
}

.idea-board-show-filter__menu {
position: static;
min-width: 12rem;
margin-top: var(--space-6);
padding: var(--space-10);
border: var(--border-standard);
border-radius: var(--radius-md);
background: var(--panel);
box-shadow: var(--shadow-md)
}

.idea-board-show-filter__options {
display: grid;
gap: var(--space-6);
margin-top: var(--space-10)
}

.idea-board-show-filter__option {
display: flex;
align-items: center;
gap: var(--space-8);
color: var(--text);
font-weight: var(--font-weight-regular);
white-space: nowrap
}

.data-table th {
color: var(--gold);
font-size: var(--font-size-sm);
Expand All @@ -60,8 +121,13 @@ td {
gap: .35em;
color: inherit;
font: inherit;
line-height: inherit;
vertical-align: baseline
line-height: var(--line-height-single);
vertical-align: baseline;
white-space: nowrap
}

.idea-board-idea-label__text {
line-height: var(--line-height-single)
}

.idea-board-idea-chevron {
Expand Down
2 changes: 1 addition & 1 deletion assets/theme-v2/js/tool-display-mode.js
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@
const diagnostic = document.createElement("p");
diagnostic.className = "status";
diagnostic.setAttribute("role", "status");
diagnostic.textContent = "Tool navigation could not load from the server API. Start the local server API and refresh.";
diagnostic.textContent = "Tool navigation is temporarily unavailable. Refresh the page or try again shortly.";
body.appendChild(diagnostic);
}
}
Expand Down
110 changes: 82 additions & 28 deletions docs_build/dev/reports/codex_changed_files.txt
Original file line number Diff line number Diff line change
@@ -1,37 +1,91 @@
# Codex Changed Files - PR_26171_063-codex-instruction-enforcement-hardening
# Codex Changed Files - PR_26171_041-idea-board-production-polish

## Conflict Resolution Note
- Merged latest `origin/main` into the PR branch after GitHub reported merge conflicts.
- Regenerated Codex artifacts from the PR_063 delta against updated `origin/main`.
- No implementation scope was changed while resolving conflicts.
## Git Workflow
- Current branch: `codex/pr-26171-041-idea-board-production-polish`.
- Expected starting branch: `main` (PASS before branch creation).
- Created branch: `codex/pr-26171-041-idea-board-production-polish`.
- Commit before conflict resolution: `ca626873a4cf19925229851b0da2a4ff55c2073f`.
- Initial push result: PASS, branch pushed to `origin/codex/pr-26171-041-idea-board-production-polish`.
- PR URL: `https://github.com/ToolboxAid/HTML-JavaScript-Gaming/pull/17`.
- Conflict resolution: merged `origin/main` at `0a364f85516aea82e38eea2f498fde5980f9adf9`; conflicts were limited to `codex_changed_files.txt` and `codex_review.diff`.
- Conflict resolution push result: pending until after merge-validation commit.
- Merge result: pending until after PR validation/merge.
- Final main sync: pending until after merge and final pull.

## Changed Files
- docs_build/dev/PROJECT_INSTRUCTIONS.md
- docs_build/dev/PROJECT_MULTI_PC.txt
- docs_build/dev/reports/PR_26171_063-codex-instruction-enforcement-hardening.md
- docs_build/dev/reports/PR_26171_063-instruction-compliance-checklist.md
- docs_build/dev/reports/PR_26171_063-validation.md
- docs_build/dev/reports/PR_26171_063-manual-validation-notes.md
- docs_build/dev/reports/codex_review.diff
- docs_build/dev/reports/codex_changed_files.txt
## Git Status
```text
M assets/theme-v2/css/tables.css
M assets/theme-v2/js/tool-display-mode.js
M docs_build/dev/reports/codex_changed_files.txt
M docs_build/dev/reports/codex_review.diff
M docs_build/dev/reports/coverage_changed_js_guardrail.txt
M docs_build/dev/reports/playwright_v8_coverage_report.txt
M src/shared/toolbox/tool-metadata-inventory.js
M tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
M tests/playwright/tools/ToolboxRoutePages.spec.mjs
M toolbox/idea-board/index.html
M toolbox/idea-board/index.js
```

## Git Diff Stat Against Updated origin/main
## Diff Stat
```text
docs_build/dev/PROJECT_INSTRUCTIONS.md | 47 ++
docs_build/dev/PROJECT_MULTI_PC.txt | 58 ++
..._063-codex-instruction-enforcement-hardening.md | 48 ++
...R_26171_063-instruction-compliance-checklist.md | 37 ++
.../PR_26171_063-manual-validation-notes.md | 19 +
docs_build/dev/reports/PR_26171_063-validation.md | 32 +
docs_build/dev/reports/codex_changed_files.txt | 48 ++
docs_build/dev/reports/codex_review.diff | 699 +++++++++------------
8 files changed, 569 insertions(+), 419 deletions(-)
assets/theme-v2/css/tables.css | 70 +++++++-
assets/theme-v2/js/tool-display-mode.js | 2 +-
.../dev/reports/coverage_changed_js_guardrail.txt | 5 +-
.../dev/reports/playwright_v8_coverage_report.txt | 11 +-
src/shared/toolbox/tool-metadata-inventory.js | 6 +-
.../playwright/tools/IdeaBoardTableNotes.spec.mjs | 71 +++++++-
tests/playwright/tools/ToolboxRoutePages.spec.mjs | 26 ++-
toolbox/idea-board/index.html | 31 ++--
toolbox/idea-board/index.js | 191 ++++++++++++++++++++-
9 files changed, 368 insertions(+), 45 deletions(-)
```

## Requirement Evidence
- PASS: Removed creator-visible Create Project from the right-side Next Steps area; no disabled `data-idea-board-create-project` panel remains.
- PASS: Create Project is shown only in a Ready idea row's Actions column.
- PASS: Clicking Create Project changes the idea status from Ready to Project and replaces Create Project/Delete with Open Project and Archive.
- PASS: Project rows show Open Project and Archive and do not show Delete.
- PASS: Added Archived status; archived rows are hidden by default.
- PASS: Archived rows show Restore and Delete.
- PASS: Restore returns archived ideas to their previous non-archived status, with Refining fallback in runtime.
- PASS: Delete is guarded so Project ideas cannot be deleted unless archived first.
- PASS: Status dropdown uses New, Exploring, Refining, Ready, Project, and Archived.
- PASS: Added compact Show checkbox dropdown beside the visible table description line, with default statuses New, Exploring, Refining, Ready, and Project selected and Archived unselected.
- PASS: Show dropdown supports any checkbox combination plus Select All and Clear All.
- PASS: Updated creator-facing copy to "Capture, compare, and shape game ideas." and "Scan, compare, and update early ideas."
- PASS: Replaced creator-visible Tool Display Mode navigation error with safe copy that does not mention server/API/local server/port/implementation details.
- PASS: Chevron renders to the left of the Idea text, inline, same size, same color, and on the same text line; the whole Idea cell remains the expansion target.
- PASS: Notes count remains informational only.
- PASS: Table-first structure, inline Add Idea/Add Note, row-level Save/Cancel, status dropdown edit mode, notes indentation, and single-open accordion behavior remain covered.

## Validation
- PASS: `git diff --check` after conflict resolution.
- PASS: targeted required instruction-anchor validation after conflict resolution.
- SKIP: Playwright, because the PR explicitly requires no Playwright and changes docs/workflow only.
- PASS: `node --check toolbox/idea-board/index.js`.
- PASS: `node --check assets/theme-v2/js/tool-display-mode.js`.
- PASS: `node --check src/shared/toolbox/tool-metadata-inventory.js`.
- PASS: `node --check tests/playwright/tools/IdeaBoardTableNotes.spec.mjs`.
- PASS: `node --check tests/playwright/tools/ToolboxRoutePages.spec.mjs`.
- PASS: `npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs --project=playwright --workers=1 --reporter=line --timeout=90000`.
- PASS: `npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs --project=playwright --workers=1 --reporter=line -g "Idea Board launches" --timeout=90000`.
- PASS: `npm run test:workspace-v2` (workspace-contract lane, 5 passed).
- PASS: `git diff --check`.
- PASS: Post-conflict rerun completed after merging `origin/main` at `0a364f85516aea82e38eea2f498fde5980f9adf9`.
- PASS: Playwright V8 coverage report produced because runtime JavaScript changed.
- WARN: Coverage report marks `src/shared/toolbox/tool-metadata-inventory.js` as not collected by browser V8 coverage; advisory only per project instructions.
- SKIPPED: Full samples smoke was not run per request.

## ZIP
- Path: `tmp/PR_26171_063-codex-instruction-enforcement-hardening_delta.zip`.
- Path: `tmp/PR_26171_041-idea-board-production-polish_delta.zip`.
- Size: final size reported in the delivery summary after conflict-resolution ZIP refresh.
- Contents:
- assets/theme-v2/css/tables.css
- assets/theme-v2/js/tool-display-mode.js
- docs_build/dev/reports/codex_changed_files.txt
- docs_build/dev/reports/codex_review.diff
- docs_build/dev/reports/coverage_changed_js_guardrail.txt
- docs_build/dev/reports/playwright_v8_coverage_report.txt
- src/shared/toolbox/tool-metadata-inventory.js
- tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
- tests/playwright/tools/ToolboxRoutePages.spec.mjs
- toolbox/idea-board/index.html
- toolbox/idea-board/index.js
Loading
Loading