PR_26171_041 polish Idea Board production behavior#17
Conversation
…ea-board-production-polish # Conflicts: # docs_build/dev/reports/codex_changed_files.txt # docs_build/dev/reports/codex_review.diff
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ca626873a4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| actionButton("Delete", "delete", "ideaBoardIdeaAction"), | ||
| ); | ||
| } else { | ||
| actions.append(actionButton("Edit", "edit", "ideaBoardIdeaAction")); |
There was a problem hiding this comment.
Project rows still expose the unrestricted Edit flow, so after promoting an idea a user can click Edit, change the status from Project back to Ready/New, save, and the Delete button returns; that bypasses the new archive-before-delete protection because canDeleteIdea only checks the row’s current status. Preserve a project marker or block demoting Project rows through this edit path so created projects cannot be deleted without archiving first.
Useful? React with 👍 / 👎.
| updateStatus(root, "Idea Board could not open that project."); | ||
| return; | ||
| } | ||
| updateStatus(root, `Opening ${record.idea}.`); |
There was a problem hiding this comment.
When a user promotes a Ready idea and clicks the new primary Open Project action, this path only changes the status message and never navigates to a project workspace, selects an existing project, or opens any created project record, leaving the production row action as a dead end while telling the user it is opening. Wire this action to the actual project-open flow or avoid presenting it as an executable Open Project action.
Useful? React with 👍 / 👎.
| if (record.status !== "Archived") record.previousStatus = record.status; | ||
| record.status = "Archived"; | ||
| record.updated = today(); | ||
| if (!state.visibleStatuses.has("Archived") && state.expandedIdeaId === ideaId) { |
There was a problem hiding this comment.
When the Archived filter is enabled and an expanded project is archived, this condition leaves the row expanded; the existing expanded-notes renderer still shows Add Note plus note Edit/Delete controls, so an archived project can continue to be modified. Collapse the row and clear note edit/add state when archiving, or suppress note controls for archived rows.
Useful? React with 👍 / 👎.
2 participants
Summary
Validation
node --check toolbox/idea-board/index.jsnode --check assets/theme-v2/js/tool-display-mode.jsnode --check src/shared/toolbox/tool-metadata-inventory.jsnode --check tests/playwright/tools/IdeaBoardTableNotes.spec.mjsnode --check tests/playwright/tools/ToolboxRoutePages.spec.mjsnpx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs --project=playwright --workers=1 --reporter=line --timeout=90000npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs --project=playwright --workers=1 --reporter=line -g "Idea Board launches" --timeout=90000npm run test:workspace-v2git diff --checkorigin/mainand resolving report-only conflicts.toolbox/idea-board/index.jsandassets/theme-v2/js/tool-display-mode.js, whilesrc/shared/toolbox/tool-metadata-inventory.jsis advisory WARN as not browser-collected.Artifact
tmp/PR_26171_041-idea-board-production-polish_delta.zip