perf(sqlite): inject LIMIT before materializing SQL results (#415) - #429
Merged
Conversation
Share injectSqlLimit via sql_limit.dart and apply it in the SQLite SQL workspace so SELECT/WITH/VALUES are bounded at the engine, not only after rawQuery loads the full set. Document row-cap behavior. Closes #415
github-actions
Bot
added
performance
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
injectSqlLimittolib/core/database/sql_limit.dart(re-exported frompostgres_sql.dart)LIMITforSELECT/WITH/VALUESbeforeexecute.take(cap)as fallback; document caps indocs/user-guide.mdtest/core/database/sql_limit_test.dartCloses #415
Parent: #414
Test plan
flutter test test/core/database/sql_limit_test.dart test/core/database/postgres_sql_test.dartSELECT * FROM large_tablewithout LIMIT → status shows capped; query plan uses LIMITLIMIT 10unchangedPRAGMA/INSERTunchanged