perf(sql): clamp oversized LIMIT / FETCH (#416 onto dev) - #432
Merged
Conversation
Extend injectSqlLimit to clamp LIMIT n, LIMIT ALL, and FETCH FIRST when larger than the UI row cap so Postgres (and SQLite) engines do not buffer more rows than Preferences allow. Document the policy. Closes #416
github-actions
Bot
added
performance
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-lands #430 onto
dev. The previous PR was stacked onissue/415-…and merged there after #429 already landed ondev, so the clamp never reacheddev.Closes #416
Parent: #414