LabKeyErrorPageTest: update testServerConfigurationErrors#3049
Merged
Conversation
labkey-nicka
approved these changes
Jun 16, 2026
4 tasks
…configuration errors
labkey-alan
force-pushed
the
fb_refuse_insecure_puppeteer
branch
from
6663139 to
24900b8
Compare
labkey-alan
added a commit
to LabKey/platform
that referenced
this pull request
Jun 23, 2026
) #### Rationale For some reason our error page was implying that a page could not be found when a configuration error was being thrown. #### Related Pull Requests - LabKey/limsModules#2260 - #7759 - LabKey/testAutomation#3049 #### Changes - ErrorHandler: Don't render "The requested page cannot be found." for configuration errors #### Tasks 📍 - [x] Claude Code Review - [x] Manual Testing - The easiest way to test this is with an http URL set for your puppeteer host e.g. http://puppeteer.example.com - [x] Test Automation (see testAutomation PR) - [x] Verify Fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
I updated the error page to no longer imply that a page could not be found when a configuration error is encountered. This PR updates the test to account for that change.
Related Pull Requests
Changes
Tasks 📍