Skip to content

ErrorHandler: don't imply page not found for configuration errors#7759

Merged
labkey-alan merged 2 commits into
developfrom
fb_refuse_insecure_puppeteer
Jun 23, 2026
Merged

ErrorHandler: don't imply page not found for configuration errors#7759
labkey-alan merged 2 commits into
developfrom
fb_refuse_insecure_puppeteer

Conversation

@labkey-alan

@labkey-alan labkey-alan commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Rationale

For some reason our error page was implying that a page could not be found when a configuration error was being thrown.

Related Pull Requests

Changes

  • ErrorHandler: Don't render "The requested page cannot be found." for configuration errors

Tasks 📍

  • Claude Code Review
  • Manual Testing
  • Test Automation (see testAutomation PR)
  • Verify Fix

@labkey-alan labkey-alan force-pushed the fb_refuse_insecure_puppeteer branch from ffa7cf0 to db824bf Compare June 22, 2026 21:24
@labkey-alan labkey-alan merged commit e98005a into develop Jun 23, 2026
7 of 10 checks passed
@labkey-alan labkey-alan deleted the fb_refuse_insecure_puppeteer branch June 23, 2026 19:58
labkey-alan added a commit to LabKey/testAutomation that referenced this pull request Jun 23, 2026
#### Rationale
I updated the error page to no longer imply that a page could not be
found when a configuration error is encountered. This PR updates the
test to account for that change.

#### Related Pull Requests
- LabKey/limsModules#2260
- LabKey/platform#7759
- #3049

#### Changes
- LabKeyErrorPageTest: update testServerConfigurationErrors to no longer
expect "The requested page cannot be found"

#### Tasks 📍
- [x] Claude Code Review
- [x] TeamCity verification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants