Detach client on disconnect in TCP server mode - #12
Merged
Conversation
unp1
force-pushed
the
fix/server-reconnect
branch
from
June 22, 2026 17:58
cb7f9b6 to
e442675
Compare
unp1
force-pushed
the
fix/server-reconnect
branch
from
June 22, 2026 18:25
e442675 to
c57686b
Compare
wadoon
approved these changes
Jun 22, 2026
wadoon
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reconnection robustness (
keyext.api):In TCP server mode
runTcpServerkeeps the loaded environments/proofs alive across client connections, but after a client disconnectedkeyApi.clientApistill referenced the now-dead remote proxy until the next client attached. Any notification fired in that window would target a dead connection.KeyApiImpl.disconnectClient()now resets the client to the no-op sink, andrunTcpServercalls it whenever a connection ends, so notifications are safely dropped until a new client attaches viasetClientApi.Test:
ClientDisconnectTestverifies the client is detached (and replaced by a non-null no-op) afterdisconnectClient().Stacked on #6 (it builds on the no-op client introduced there); retarget to
mainafter #6 merges.PR has been created with AI tooling