Skip to content

Fix post-merge exact-head validation #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hudsonaikins merged 1 commit into from
Jul 17, 2026
Merged

Fix post-merge exact-head validation #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/product-validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,15 @@ jobs:
- name: Validate exact candidate
run: |
set -o pipefail
base_ref=origin/main
if [ "$GITHUB_EVENT_NAME" = "push" ]; then
base_ref=HEAD^

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Retain the checkpoint in the narrowed push range

For the push event generated by this reviewed commit, setting the base to HEAD^ narrows checkpoint discovery to 5e9a0d3^..5e9a0d3, but this commit has no Entire-Checkpoint trailer. Because tabellio.validation.json sets requireEntireCheckpoint to true, ValidationRunner.run finds an empty checkpoint list and throws before running any validators, so the exact-head validation this patch is intended to repair still fails for its own pushed SHA.

Useful? React with 👍 / 👎.

fi
install -m 755 scripts/tabellio-validator.mjs "$RUNNER_TEMP/tabellio-validator"
PATH="$RUNNER_TEMP:$PATH" node scripts/tabellio-validate.mjs gate \
--repo . \
--repo-id IntelIP/Tabellio \
--base origin/main \
--base "$base_ref" \
--commit HEAD \
--manifest tabellio.validation.json | tee tabellio-validation-result.json
- name: Upload validation result
Expand Down
Loading