Fix post-merge exact-head validation#22
Conversation
Entire-Checkpoint: 32fbf2c327b4
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d5a81393da
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| set -o pipefail | ||
| base_ref=origin/main | ||
| if [ "$GITHUB_EVENT_NAME" = "push" ]; then | ||
| base_ref=HEAD^ |
There was a problem hiding this comment.
Retain the checkpoint in the narrowed push range
For the push event generated by this reviewed commit, setting the base to HEAD^ narrows checkpoint discovery to 5e9a0d3^..5e9a0d3, but this commit has no Entire-Checkpoint trailer. Because tabellio.validation.json sets requireEntireCheckpoint to true, ValidationRunner.run finds an empty checkpoint list and throws before running any validators, so the exact-head validation this patch is intended to repair still fails for its own pushed SHA.
Useful? React with 👍 / 👎.
Summary
origin/mainHEAD^Validation
c4789837: emptyHEAD..HEADcheckpoint ranged5a81393dabc6c52c88dd6f37a5b30267b471022Rollout boundary
Merge authorized. No deployment.