Skip to content

Fix post-merge exact-head validation#22

Merged
hudsonaikins merged 1 commit into
mainfrom
codex/tabellio-postmerge-validation
Jul 17, 2026
Merged

Fix post-merge exact-head validation#22
hudsonaikins merged 1 commit into
mainfrom
codex/tabellio-postmerge-validation

Conversation

@hudsonaikins

Copy link
Copy Markdown
Contributor

Summary

  • validate pull-request heads against origin/main
  • validate landed push commits against HEAD^
  • preserve exact landed-commit evidence without producing an empty checkpoint range

Validation

  • reproduced the landed failure at c4789837: empty HEAD..HEAD checkpoint range
  • exact hotfix commit: d5a81393dabc6c52c88dd6f37a5b30267b471022
  • 98/98 tests passed outside the restricted sandbox
  • local product gate reached all validators; only loopback-listener tests were blocked by the local sandbox
  • GitHub exact-head product validation is authoritative

Rollout boundary

Merge authorized. No deployment.

Entire-Checkpoint: 32fbf2c327b4

Copy link
Copy Markdown
Contributor Author

@codex review

@hudsonaikins
hudsonaikins merged commit 70fbcb0 into main Jul 17, 2026
4 checks passed
@hudsonaikins
hudsonaikins deleted the codex/tabellio-postmerge-validation branch July 17, 2026 03:10

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d5a81393da

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

set -o pipefail
base_ref=origin/main
if [ "$GITHUB_EVENT_NAME" = "push" ]; then
base_ref=HEAD^

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Retain the checkpoint in the narrowed push range

For the push event generated by this reviewed commit, setting the base to HEAD^ narrows checkpoint discovery to 5e9a0d3^..5e9a0d3, but this commit has no Entire-Checkpoint trailer. Because tabellio.validation.json sets requireEntireCheckpoint to true, ValidationRunner.run finds an empty checkpoint list and throws before running any validators, so the exact-head validation this patch is intended to repair still fails for its own pushed SHA.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant