Mutex in tx monitor - #264
Merged
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
10 tasks
GabrielMartinezRodriguez
marked this pull request as ready for review
November 20, 2024 14:26
Deploying happychain with
|
| Latest commit: |
89f8e7e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://22bbb714.happychain.pages.dev |
| Branch Preview URL: | https://gabriel-tx-monitor-lock.happychain.pages.dev |
HAPPY-136 txmanager: Avoid overlapping TxMonitor executions
cf. #182 (comment) Maybe needed in some other blocks that listen on new blocks and do RPC calls? |
AryanGodara
reviewed
Nov 20, 2024
not-reed
reviewed
Nov 20, 2024
AryanGodara
approved these changes
Nov 22, 2024
not-reed
approved these changes
Nov 25, 2024
Merged
10 tasks
GabrielMartinezRodriguez
force-pushed
the
gabriel-txm-purge
branch
from
December 4, 2024 10:26
87bddea to
87025fe
Compare
GabrielMartinezRodriguez
force-pushed
the
gabriel/tx-monitor-lock
branch
from
December 4, 2024 10:26
e20494b to
96c21fc
Compare
10 tasks
GabrielMartinezRodriguez
force-pushed
the
gabriel-txm-purge
branch
from
December 5, 2024 10:47
87025fe to
7f8df16
Compare
GabrielMartinezRodriguez
force-pushed
the
gabriel/tx-monitor-lock
branch
from
December 5, 2024 10:47
96c21fc to
7a69327
Compare
GabrielMartinezRodriguez
force-pushed
the
gabriel-txm-purge
branch
from
December 5, 2024 11:33
7f8df16 to
5934aaf
Compare
GabrielMartinezRodriguez
force-pushed
the
gabriel/tx-monitor-lock
branch
from
December 5, 2024 11:34
7a69327 to
65b547a
Compare
GabrielMartinezRodriguez
force-pushed
the
gabriel-txm-purge
branch
from
December 5, 2024 15:29
5934aaf to
3687fca
Compare
GabrielMartinezRodriguez
force-pushed
the
gabriel/tx-monitor-lock
branch
from
December 5, 2024 15:29
65b547a to
2ecd54a
Compare
GabrielMartinezRodriguez
force-pushed
the
gabriel/tx-monitor-lock
branch
2 times, most recently
from
December 20, 2024 11:22
0812786 to
b2791e0
Compare
Merged
10 tasks
norswap
approved these changes
Dec 21, 2024
| "@happychain/common": "workspace:^", | ||
| "@happychain/configs": "workspace:^", | ||
| "@happychain/contracts": "workspace:^", | ||
| "async-mutex": "^0.5.0", |
Collaborator
There was a problem hiding this comment.
We don't need this one anymore :)
GabrielMartinezRodriguez
force-pushed
the
gabriel/tx-monitor-lock
branch
from
December 23, 2024 14:27
c476899 to
1e393b6
Compare
This was referenced Dec 26, 2024
GabrielMartinezRodriguez
force-pushed
the
gabriel/tx-monitor-lock
branch
from
December 27, 2024 12:30
9cb1341 to
89f8e7e
Compare
This was referenced Jan 22, 2025
This was referenced Feb 3, 2025
Merged
This was referenced Feb 11, 2025
Closed
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Linked Issues
Description
This PR implements a mutex in the TxMonitor class to prevent overlapping executions of multiple transactions. Additionally, if more than one process is waiting to acquire the mutex, only the last process will acquire it, and the previous ones will be discarded
Toggle Checklist
Checklist
Basics
norswap/build-system-caching).Reminder: PR review guidelines
Correctness
testnet, mainnet, standalone wallet, ...).
This PR has been tested using the randomness service on localhost, interacting with the Anvil blockchain and simulating that a monitoring execution took longer than expected to verify that the mutex was working properly
and have updated the code & comments accordingly.
Architecture & Documentation
(2) commenting these boundaries correctly, (3) adding inline comments for context when needed.
comments.
in a Markdown document.