Increase default RPC timeout to 2000ms - #365
Merged
Merged
Conversation
10 tasks
Contributor
Author
10 tasks
GabrielMartinezRodriguez
marked this pull request as ready for review
January 22, 2025 15:07
Deploying happychain with
|
| Latest commit: |
4722d38
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bdd92e7b.happychain.pages.dev |
| Branch Preview URL: | https://gabriel-txm-increase-timeout.happychain.pages.dev |
HAPPY-308 Increase the default timeout to allow the gas estimator to spend more time
The default timeout is now 500ms, which is too low if you need to simulate a transaction to measure the gas limit |
10 tasks
GabrielMartinezRodriguez
force-pushed
the
gabriel/txm-increase-timeout
branch
from
January 22, 2025 16:39
8e4376e to
a7c5995
Compare
not-reed
approved these changes
Jan 22, 2025
GabrielMartinezRodriguez
force-pushed
the
gabriel/txm-http-polling-interval
branch
from
January 23, 2025 10:37
df46fd6 to
f48f94c
Compare
This was referenced Jan 23, 2025
Merged
Merged
Merged
GabrielMartinezRodriguez
force-pushed
the
gabriel/txm-increase-timeout
branch
from
January 23, 2025 10:38
a7c5995 to
f238ce6
Compare
10 tasks
GabrielMartinezRodriguez
force-pushed
the
gabriel/txm-http-polling-interval
branch
from
January 23, 2025 14:44
f48f94c to
0b937a8
Compare
GabrielMartinezRodriguez
force-pushed
the
gabriel/txm-increase-timeout
branch
from
January 23, 2025 14:45
f238ce6 to
6ddafa5
Compare
norswap
approved these changes
Jan 31, 2025
GabrielMartinezRodriguez
force-pushed
the
gabriel/txm-http-polling-interval
branch
from
January 31, 2025 14:44
0b937a8 to
9fa6f10
Compare
GabrielMartinezRodriguez
force-pushed
the
gabriel/txm-increase-timeout
branch
from
January 31, 2025 14:44
6ddafa5 to
352683b
Compare
Merged
10 tasks
GabrielMartinezRodriguez
force-pushed
the
gabriel/txm-http-polling-interval
branch
from
February 3, 2025 12:40
9fa6f10 to
9cee1b9
Compare
GabrielMartinezRodriguez
force-pushed
the
gabriel/txm-increase-timeout
branch
from
February 3, 2025 12:41
352683b to
0303189
Compare
GabrielMartinezRodriguez
force-pushed
the
gabriel/txm-http-polling-interval
branch
from
February 3, 2025 13:14
9cee1b9 to
61a2966
Compare
GabrielMartinezRodriguez
force-pushed
the
gabriel/txm-increase-timeout
branch
from
February 3, 2025 13:15
0303189 to
6123c34
Compare
GabrielMartinezRodriguez
force-pushed
the
gabriel/txm-http-polling-interval
branch
from
February 4, 2025 13:51
61a2966 to
6655ac3
Compare
GabrielMartinezRodriguez
force-pushed
the
gabriel/txm-increase-timeout
branch
from
February 4, 2025 13:51
6123c34 to
440728c
Compare
GabrielMartinezRodriguez
force-pushed
the
gabriel/txm-http-polling-interval
branch
from
February 5, 2025 14:03
6655ac3 to
991bf7f
Compare
GabrielMartinezRodriguez
force-pushed
the
gabriel/txm-increase-timeout
branch
from
February 5, 2025 14:03
440728c to
877ca68
Compare
10 tasks
Base automatically changed from
gabriel/txm-http-polling-interval
to
gabriel/txm-force-initialization
February 5, 2025 16:07
GabrielMartinezRodriguez
force-pushed
the
gabriel/txm-force-initialization
branch
6 times, most recently
from
February 10, 2025 18:58
0c3569a to
0e8184e
Compare
aodhgan
force-pushed
the
gabriel/txm-force-initialization
branch
from
February 10, 2025 20:12
11296ce to
2e6b4ea
Compare
norswap
force-pushed
the
gabriel/txm-increase-timeout
branch
from
February 10, 2025 20:23
877ca68 to
fab80c3
Compare
GabrielMartinezRodriguez
force-pushed
the
gabriel/txm-increase-timeout
branch
from
February 10, 2025 20:25
fab80c3 to
4722d38
Compare
This was referenced Feb 11, 2025
Closed
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Linked Issues
Description
The default timeout is now 500ms, which is too low if you need to simulate a transaction to measure the gas limit
Toggle Checklist
Checklist
Basics
norswap/build-system-caching).Reminder: PR review guidelines
Correctness
C1. Builds and passes tests.
C2. The code is properly parameterized & compatible with different environments (e.g. local,
testnet, mainnet, standalone wallet, ...).
C3. I have manually tested my changes & connected features.
C4. I have performed a thorough self-review of my code after submitting the PR,
and have updated the code & comments accordingly.
Architecture & Documentation
(2) commenting these boundaries correctly, (3) adding inline comments for context when needed.
comments.
in a Markdown document.