-
-
Notifications
You must be signed in to change notification settings - Fork 395
London | 26-ITP-May | Damilola Odumosu| Sprint 3 | Practice TDD #1538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
d-odumosu
wants to merge
4
commits into
CodeYourFuture:main
Choose a base branch
from
d-odumosu:coursework/sprint-3-practice-tdd
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
a3b9260
completed jest testing on count test and implemented the function
d-odumosu d85efd8
completed jest testing on ordinal numbers and implemented the function
d-odumosu 248d2a4
completed jest testing o and implemented the function as required
d-odumosu f641d30
all requirements completed
d-odumosu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,15 @@ | ||
| function countChar(stringOfCharacters, findCharacter) { | ||
| return 5 | ||
| } | ||
| if(stringOfCharacters === "" || findCharacter === ""){ | ||
| throw new Error("string an char are not given") | ||
| } | ||
|
|
||
| const str = stringOfCharacters.split("") | ||
| let count = 0; | ||
| for(const char of str){ | ||
| if(char === findCharacter){ | ||
| count++ | ||
| } | ||
| } | ||
| return count | ||
| } | ||
| module.exports = countChar; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,31 @@ | ||
| function getOrdinalNumber(num) { | ||
| return "1st"; | ||
| const numberStr1 = String(num).slice(-1) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. variable names could be more descriptive |
||
| const numberStr2 = String(num).slice(-2) | ||
|
|
||
| let number1 = Number(numberStr1) | ||
| let number2 = Number(numberStr2) | ||
|
|
||
| if (number2 === 11 || number2 === 12 || number2 === 13) { | ||
| return `${num}th` | ||
| } | ||
| else { | ||
|
|
||
| switch (number1) { | ||
| case 1: | ||
| return`${num}st` | ||
| break; | ||
| case 2: | ||
| return `${num}nd` | ||
| break; | ||
| case 3: | ||
| return `${num}rd` | ||
| break; | ||
| default: | ||
| return`${num}th`; | ||
| } | ||
| } | ||
|
|
||
| } | ||
|
|
||
|
|
||
| module.exports = getOrdinalNumber; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,24 @@ | ||
| function repeatStr() { | ||
| // Your implementation of this function must *not* call String.prototype.repeat (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/repeat). | ||
| // The goal is to re-implement that function, not to use it. | ||
| return "hellohellohello"; | ||
| } | ||
| function repeatStr(word, wordCounter) { | ||
| // Your implementation of this function must *not* call String.prototype.repeat (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/repeat). | ||
| // The goal is to re-implement that function, not to use it. | ||
| let count = 0; | ||
| let repeatedString = [] | ||
|
|
||
| if (wordCounter < 0) { // rejects negative numbers | ||
| throw new Error("Enter a positive number") | ||
| } | ||
| if(wordCounter === 0){ | ||
| return "" | ||
| } | ||
| if(wordCounter === 1){ | ||
| return word | ||
| } | ||
| if(wordCounter > 1){ | ||
| while(count < wordCounter){ | ||
| count++ | ||
| repeatedString.push(word) | ||
| } | ||
| } | ||
| return repeatedString.join("") | ||
| } | ||
| module.exports = repeatStr; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
String are iterable in JS, so no need for the split function here.