London | 26-ITP-May | Damilola Odumosu| Sprint 3 | Practice TDD#1538
Open
d-odumosu wants to merge 4 commits into
Open
London | 26-ITP-May | Damilola Odumosu| Sprint 3 | Practice TDD#1538d-odumosu wants to merge 4 commits into
d-odumosu wants to merge 4 commits into
Conversation
d-odumosu
added
Needs Review
hey-hammad
added
Review in progress
hey-hammad
suggested changes
Jul 25, 2026
hey-hammad
left a comment
hey-hammad
left a comment
There was a problem hiding this comment.
Good implementation, couple of minor changes required.
| throw new Error("string an char are not given") | ||
| } | ||
|
|
||
| const str = stringOfCharacters.split("") |
There was a problem hiding this comment.
String are iterable in JS, so no need for the split function here.
| @@ -1,5 +1,31 @@ | |||
| function getOrdinalNumber(num) { | |||
| return "1st"; | |||
| const numberStr1 = String(num).slice(-1) | |||
There was a problem hiding this comment.
variable names could be more descriptive
hey-hammad
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Completed all requirements of practice TDD