-
-
Notifications
You must be signed in to change notification settings - Fork 395
London | May-2026-itp | Vitalii Kmit | Sprint 3 | practice TDD coursework #1527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Vitalii-code
wants to merge
9
commits into
CodeYourFuture:main
Choose a base branch
from
Vitalii-code:coursework/sprint-3-practice-tdd
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
de7f533
Add a test for countChar
Vitalii-code dda4bf7
Change the input of a test to be smaller
Vitalii-code 274894e
Write tests for repeat-str.js
Vitalii-code 12ce863
Write tests for get-ordinal-number.js
Vitalii-code 1a1df6f
Implement countChar in count.js
Vitalii-code db30440
Fix tests for repeat-str.js
Vitalii-code 73f8459
Implement repeat-str
Vitalii-code 1a4ec4e
Add more tests to cover 10,11,12,13
Vitalii-code f1f96b4
Implement getOrdinalNumber
Vitalii-code File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,13 @@ | ||
| function countChar(stringOfCharacters, findCharacter) { | ||
| return 5 | ||
| let count = 0; | ||
|
|
||
| for (const i of stringOfCharacters) { | ||
| if (i === findCharacter) { | ||
| count++; | ||
| } | ||
| } | ||
|
|
||
| return count; | ||
| } | ||
|
|
||
| module.exports = countChar; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,31 @@ | ||
| function getOrdinalNumber(num) { | ||
| return "1st"; | ||
| // handle special cases | ||
|
|
||
| if (typeof num !== "number" || Number.isNaN(num)) { | ||
| throw new Error(`Invalid type for ${num}, expected Number`); | ||
| } | ||
|
|
||
| const snum = String(num); // num as a string | ||
| const thList = ["0", "4", "5", "6", "7", "8", "9", "10", "11", "12", "13"]; // list of numbers that should end up with th as a suffix | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you can drop the 0,4,5... from the list here and handle them in switch for the "th" scenario. |
||
|
|
||
| const lastCharIndex = snum.length - 1; | ||
| const lastOne = snum[lastCharIndex]; | ||
| const lastTwo = snum.slice(lastCharIndex - 1); | ||
|
|
||
| if (thList.includes(lastTwo) || thList.includes(lastOne)) { | ||
| return snum + "th"; | ||
| } | ||
|
|
||
| switch (lastOne) { | ||
| case "1": | ||
| return snum + "st"; | ||
| case "2": | ||
| return snum + "nd"; | ||
| case "3": | ||
| return snum + "rd"; | ||
| default: | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| module.exports = getOrdinalNumber; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,17 @@ | ||
| function repeatStr() { | ||
| function repeatStr(str, count) { | ||
| // Your implementation of this function must *not* call String.prototype.repeat (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/repeat). | ||
| // The goal is to re-implement that function, not to use it. | ||
| return "hellohellohello"; | ||
| if (count < 0) { | ||
| throw new Error("Expected a positive integer"); | ||
| } | ||
|
|
||
| let out = ""; | ||
|
|
||
| for (let i = 0; i < count; i++) { | ||
| out = out + str; | ||
| } | ||
|
|
||
| return out; | ||
| } | ||
|
|
||
| module.exports = repeatStr; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a decimal number will still pass through this guard block, can you think of a better way to make this more robust?