London | May-2026-itp | Vitalii Kmit | Sprint 3 | practice TDD coursework#1527
Open
Vitalii-code wants to merge 9 commits into
Open
London | May-2026-itp | Vitalii Kmit | Sprint 3 | practice TDD coursework#1527Vitalii-code wants to merge 9 commits into
Vitalii-code wants to merge 9 commits into
Conversation
Vitalii-code
added
the
Needs Review
hey-hammad
added
Review in progress
hey-hammad
suggested changes
Jul 25, 2026
hey-hammad
left a comment
hey-hammad
left a comment
There was a problem hiding this comment.
Good Implementation overall, couple of minor fixes required.
| return "1st"; | ||
| // handle special cases | ||
|
|
||
| if (typeof num !== "number" || Number.isNaN(num)) { |
There was a problem hiding this comment.
a decimal number will still pass through this guard block, can you think of a better way to make this more robust?
| } | ||
|
|
||
| const snum = String(num); // num as a string | ||
| const thList = ["0", "4", "5", "6", "7", "8", "9", "10", "11", "12", "13"]; // list of numbers that should end up with th as a suffix |
There was a problem hiding this comment.
you can drop the 0,4,5... from the list here and handle them in switch for the "th" scenario.
hey-hammad
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Worked on the coursework by writing tests first and then code for them