-
-
Notifications
You must be signed in to change notification settings - Fork 318
London | 26-ITP-May | Dipa Sarker | Sprint 1| Sprint-1-exercises #1244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Dipa-Sarker
wants to merge
9
commits into
CodeYourFuture:main
Choose a base branch
from
Dipa-Sarker:Sprint-1-exercises
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4c97776
fix implementation for calculating median
Dipa-Sarker d4a5843
implement dedupe function and tests
Dipa-Sarker df692dd
implement function and tests for max number
Dipa-Sarker 4680671
implement sum function and tests
Dipa-Sarker 4a2cb1a
refactored function using for...of loop
Dipa-Sarker e78408c
refactored function using for...of loop
Dipa-Sarker 5b49ae1
solved frequency for input.txt
Dipa-Sarker 540f170
modified the function
Dipa-Sarker e6a2401
completed median.js for all tests
Dipa-Sarker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,10 @@ | ||
| function dedupe() {} | ||
| function dedupe(array) { | ||
| if (array.length === 0) { | ||
| return []; | ||
| } | ||
| const set = new Set(array); | ||
| const newArray = Array.from(set); | ||
| return newArray; | ||
| } | ||
|
|
||
| module.exports = dedupe; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,28 +1,40 @@ | ||
| const dedupe = require("./dedupe.js"); | ||
| /* | ||
| Dedupe Array | ||
|
|
||
| 📖 Dedupe means **deduplicate** | ||
| describe("dedupe", () => { | ||
| test("given an empty array, it should return an empty array", () => { | ||
| expect(dedupe([])).toEqual([]); | ||
| }); | ||
| test.each([ | ||
| { | ||
| input: [1, 2, 3, 4], | ||
| expected: [1, 2, 3, 4], | ||
| }, | ||
| { | ||
| input: ["a", "b", "c"], | ||
| expected: ["a", "b", "c"], | ||
| }, | ||
| ])("returns a copy of an array with no duplicates", ({ input, expected }) => { | ||
| const result = dedupe(input); | ||
|
|
||
| In this kata, you will need to deduplicate the elements of an array | ||
| expect(result).toEqual(expected); | ||
| expect(result).not.toBe(input); | ||
| }); | ||
| test.each([ | ||
| { | ||
| input: ["a", "c", "b", "d", "c", "d"], | ||
| expected: ["a", "c", "b", "d"], | ||
| }, | ||
| { | ||
| input: [1, 2, 3, 2, 4, 3], | ||
| expected: [1, 2, 3, 4], | ||
| }, | ||
| ])( | ||
| "given an array with duplicates, it should remove duplicates and preserve first occurrence", | ||
| ({ input, expected }) => { | ||
| const result = dedupe(input); | ||
|
|
||
| E.g. dedupe(['a','a','a','b','b','c']) returns ['a','b','c'] | ||
| E.g. dedupe([5, 1, 1, 2, 3, 2, 5, 8]) returns [5, 1, 2, 3, 8] | ||
| E.g. dedupe([1, 2, 1]) returns [1, 2] | ||
| */ | ||
|
|
||
| // Acceptance Criteria: | ||
|
|
||
| // Given an empty array | ||
| // When passed to the dedupe function | ||
| // Then it should return an empty array | ||
| test.todo("given an empty array, it returns an empty array"); | ||
|
|
||
| // Given an array with no duplicates | ||
| // When passed to the dedupe function | ||
| // Then it should return a copy of the original array | ||
|
|
||
| // Given an array of strings or numbers | ||
| // When passed to the dedupe function | ||
| // Then it should return a new array with duplicates removed while preserving the | ||
| // first occurrence of each element from the original array. | ||
| expect(result).toEqual(expected); | ||
| expect(result).not.toBe(input); | ||
| } | ||
| ); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,12 @@ | ||
| function findMax(elements) { | ||
| function findMax(array) { | ||
| let result = -Infinity; | ||
|
|
||
| for (const element of array) { | ||
| if (typeof element === "number" && element > result) { | ||
| result = element; | ||
| } | ||
| } | ||
| return result; | ||
| } | ||
|
|
||
| module.exports = findMax; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,43 +1,31 @@ | ||
| /* Find the maximum element of an array of numbers | ||
|
|
||
| In this kata, you will need to implement a function that find the largest numerical element of an array. | ||
|
|
||
| E.g. max([30, 50, 10, 40]), target output: 50 | ||
| E.g. max(['hey', 10, 'hi', 60, 10]), target output: 60 (sum ignores any non-numerical elements) | ||
|
|
||
| You should implement this function in max.js, and add tests for it in this file. | ||
|
|
||
| We have set things up already so that this file can see your function from the other file. | ||
| */ | ||
|
|
||
| const findMax = require("./max.js"); | ||
|
|
||
| // Given an empty array | ||
| // When passed to the max function | ||
| // Then it should return -Infinity | ||
| // Delete this test.todo and replace it with a test. | ||
| test.todo("given an empty array, returns -Infinity"); | ||
| describe("findMax", () => { | ||
| test("given an empty array, it should return -Infinity", () => { | ||
| expect(findMax([])).toEqual(-Infinity); | ||
| }); | ||
|
|
||
| // Given an array with one number | ||
| // When passed to the max function | ||
| // Then it should return that number | ||
| test("given array with one number, it should return that number", () => { | ||
| expect(findMax([5])).toEqual(5); | ||
| }); | ||
|
|
||
| // Given an array with both positive and negative numbers | ||
| // When passed to the max function | ||
| // Then it should return the largest number overall | ||
| test("given array with both +ve and -ve numbers, it should return the largest number overall", () => { | ||
| expect(findMax([-10, 5, -20, 3])).toEqual(5); | ||
| }); | ||
|
|
||
| // Given an array with just negative numbers | ||
| // When passed to the max function | ||
| // Then it should return the closest one to zero | ||
| test("given array with only -ve numbers, it should return the closest one to zero", () => { | ||
| expect(findMax([-10, -20, -30, -40])).toEqual(-10); | ||
| }); | ||
|
|
||
| // Given an array with decimal numbers | ||
| // When passed to the max function | ||
| // Then it should return the largest decimal number | ||
| test("given array with decimal numbers, it should return the largest decimal number", () => { | ||
| expect(findMax([0.5, 0.12, 5.6, 0.002])).toEqual(5.6); | ||
| }); | ||
|
|
||
| // Given an array with non-number values | ||
| // When passed to the max function | ||
| // Then it should return the max and ignore non-numeric values | ||
| test("given array with non-number values, it should return the max and ignore non-numeric values", () => { | ||
| expect(findMax([5, "a", 10, "cat", 3, "b"])).toEqual(10); | ||
| }); | ||
|
|
||
| // Given an array with only non-number values | ||
| // When passed to the max function | ||
| // Then it should return the least surprising value given how it behaves for all other inputs | ||
| test("given array with only non-number values, it should return -infinity", () => { | ||
| expect(findMax(["cow", "cat", "dog"])).toEqual(-Infinity); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,11 @@ | ||
| function sum(elements) { | ||
| function sum(array) { | ||
| let result = 0; | ||
| for (const element of array) { | ||
| if (typeof element === "number") { | ||
| result += element; | ||
| } | ||
| } | ||
| return result; | ||
| } | ||
|
|
||
| module.exports = sum; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,36 +1,27 @@ | ||
| /* Sum the numbers in an array | ||
|
|
||
| In this kata, you will need to implement a function that sums the numerical elements of an array | ||
|
|
||
| E.g. sum([10, 20, 30]), target output: 60 | ||
| E.g. sum(['hey', 10, 'hi', 60, 10]), target output: 80 (ignore any non-numerical elements) | ||
| */ | ||
|
|
||
| const sum = require("./sum.js"); | ||
|
|
||
| // Acceptance Criteria: | ||
|
|
||
| // Given an empty array | ||
| // When passed to the sum function | ||
| // Then it should return 0 | ||
| test.todo("given an empty array, returns 0") | ||
| describe("sum", () => { | ||
| test("given an empty array, it should return 0", () => { | ||
| expect(sum([])).toEqual(0); | ||
| }); | ||
|
|
||
| // Given an array with just one number | ||
| // When passed to the sum function | ||
| // Then it should return that number | ||
| test("given array with one number, it should return that number", () => { | ||
| expect(sum([5])).toEqual(5); | ||
| }); | ||
|
|
||
| // Given an array containing negative numbers | ||
| // When passed to the sum function | ||
| // Then it should still return the correct total sum | ||
| test("given array with only -ve numbers, it should return the correct total sum", () => { | ||
| expect(sum([-10, -20, -30, -40])).toEqual(-100); | ||
| }); | ||
|
|
||
| // Given an array with decimal/float numbers | ||
| // When passed to the sum function | ||
| // Then it should return the correct total sum | ||
| test("given array with only decimal/float numbers, it should return the correct total sum", () => { | ||
| expect(sum([0.5, 0.12, 3.14, 0.002])).toEqual(3.762); | ||
| }); | ||
|
|
||
| // Given an array containing non-number values | ||
| // When passed to the sum function | ||
| // Then it should ignore the non-numerical values and return the sum of the numerical elements | ||
| test("given array with non-number values, it should return the sum of the numerical elements", () => { | ||
| expect(sum([1, "a", 0.5, "b", -10])).toEqual(-8.5); | ||
| }); | ||
|
|
||
| // Given an array with only non-number values | ||
| // When passed to the sum function | ||
| // Then it should return the least surprising value given how it behaves for all other inputs | ||
| test("given array with only non-number values, it should return 0", () => { | ||
| expect(sum(["cow", "cat", "dog"])).toEqual(0); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| const fs = require("fs"); | ||
|
|
||
| const text = fs.readFileSync("./input.txt", "utf8"); | ||
|
|
||
| const numbers = text | ||
| .trim() | ||
| .split("\n") | ||
| .map(Number); | ||
|
|
||
| let frequency = 0; | ||
|
|
||
| for (const number of numbers) { | ||
| frequency += number; | ||
| } | ||
|
|
||
| console.log(frequency); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you run the tests for this file? When I run it, I get a failure, do you also get this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am extremely sorry that may be by mistakenly I did not complete the function for all the test cases and forgot to run the test file. Now, I completed all the functions for the test cases.