London | 26-ITP-May | Dipa Sarker | Sprint 1| Sprint-1-exercises

[Dipa-Sarker]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

Completed the Sprint 1 tasks across the Fix, Implement and Refactor sections.

1. Fix

• Ran and analyzed failing tests.
• Updated implementations to ensure all provided tests pass.
• Verified fixes against the existing test suite.

2. Implement

Implemented functions according to the provided requirements:

• max
• sum
• dedupe

Added/verified functionality against the corresponding test cases and checked behavior with different inputs.

3. Refactor

• Refactored the provided implementations as requested.
• Ensured existing functionality was preserved.
• Re-ran tests to confirm no regressions were introduced.

Testing

• Ran the Fix test suite: npm test -- fix
• Ran the Implement test suite: npm test -- implement
• Re-ran all relevant tests after refactoring.
• Confirmed all tests are passing.

4. Also completed input.txt solution in stretch.

[LonMcGregor]

Good start, but some areas where you could improve

[LonMcGregor]

Did you run the tests for this file? When I run it, I get a failure, do you also get this?

[Dipa-Sarker]

I am extremely sorry that may be by mistakenly I did not complete the function for all the test cases and forgot to run the test file. Now, I completed all the functions for the test cases.

[LonMcGregor]

Are all the lines of code in this function necessary for it to work? Could it be simplified?

[Dipa-Sarker]

I think there is no need to const result = []; I removed this line and added return []; directly inside the if condition.

[LonMcGregor]

Great, task is complete