Skip to content

GAUD-10274: Removes d2l-label-text usage and typography.scss import #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EdwinACL831 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

GAUD-10274: Removes d2l-label-text usage and typography.scss import #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2797b52
Removes d2l-label-text usage and typography.scss import
Jul 8, 2026
abad61b
Removes the d2l-button.scss file
Jul 9, 2026
bb3332e
Removes the button.css.scss test file
Jul 9, 2026
e062b6e
Removes sass scripts and sass dependency and exposure of d2l-button.scss
Jul 9, 2026
2077b7b
Removes unnecessary .gitignore file
Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
168 changes: 0 additions & 168 deletions d2l-button.scss
View file
Open in desktop

This file was deleted.

7 changes: 2 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,17 @@
},
"name": "@brightspace-ui/button",
"scripts": {
"build:sass": "sass ./test/button.css.scss ./test/button.css --no-source-map",
"lint": "npm run lint:js",
"lint:js": "eslint . --ext .js,.html demo/**/*.html",
"start": "web-dev-server --node-resolve --watch",
"test": "npm run lint && npm run build:sass"
"test": "npm run lint"
},
"author": "D2L Corporation",
"license": "Apache-2.0",
"devDependencies": {
"@web/dev-server": "^0.4",
"eslint": "^9",
"eslint-config-brightspace": "^4",
"sass": "^1"

@EdwinACL831 EdwinACL831 Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no need to use sass dependency here since there are no more sass files in this project.

"eslint-config-brightspace": "^4"
},
"version": "6.4.0",
"main": "d2l-button.js",
Expand All @@ -28,7 +26,6 @@
"d2l-button-shared-styles.js",
"d2l-button-subtle.js",
"d2l-button.js",
"d2l-button.scss",
"d2l-floating-buttons.js"
],
"publishConfig": {
Expand Down
1 change: 0 additions & 1 deletion test/.gitignore
View file
Open in desktop

@EdwinACL831 EdwinACL831 Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file is no longer needed since we removed the button.css.scss. So it no longer has any purpose.

This file was deleted.

13 changes: 0 additions & 13 deletions test/button.css.scss
View file
Open in desktop

This file was deleted.