GAUD-10274: Removes d2l-label-text usage and typography.scss import#211
Open
EdwinACL831 wants to merge 5 commits into
Open
GAUD-10274: Removes d2l-label-text usage and typography.scss import#211EdwinACL831 wants to merge 5 commits into
EdwinACL831 wants to merge 5 commits into
Conversation
EdwinACL831
force-pushed
the
ecollazos/GAUD-10274_remove_typography_dependency
branch
from
a91038a to
2797b52
Compare
dlockhart
reviewed
Jul 8, 2026
EdwinACL831
commented
Jul 9, 2026
Contributor
Author
There was a problem hiding this comment.
I think this file is no longer needed since we removed the button.css.scss. So it no longer has any purpose.
EdwinACL831
commented
Jul 9, 2026
| "@web/dev-server": "^0.4", | ||
| "eslint": "^9", | ||
| "eslint-config-brightspace": "^4", | ||
| "sass": "^1" |
Contributor
Author
There was a problem hiding this comment.
there is no need to use sass dependency here since there are no more sass files in this project.
dlockhart
reviewed
Jul 9, 2026
| @@ -1,13 +0,0 @@ | |||
| @import '../d2l-button.scss'; | |||
|
|
|||
| .sass-mixin-button { | |||
Member
There was a problem hiding this comment.
These CSS classes are used in some of the demos -- so those can be removed as well, as can the import of ./test/button.css.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira
GAUD-10274
Description
According to this thread in slack, it is safe to remove the core's typography.scss dependency in this project. That is because the only place that uses the SASS styles generated from here is in cim-picker, and the version used there is the 4.10.4. If you look at that tag in the
brightspace-ui/buttonproject (this one) you will see that there is no reference to core but to bower's typography