Skip to content

fix(publish): exact-pin sherpa-onnx 1.13.5 + matching win-x86 prebuilt #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willwade merged 1 commit into from
Aug 16, 2026
Merged

fix(publish): exact-pin sherpa-onnx 1.13.5 + matching win-x86 prebuilt #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,13 +141,20 @@ jobs:
if: matrix.target == 'x86_64-unknown-linux-gnu'
run: sudo apt-get update && sudo apt-get install -y libspeechd-dev libclang-dev
- name: Download sherpa-onnx x86 prebuilt (32-bit Windows only)
# sherpa-onnx-sys doesn't auto-detect win-x86 yet, but the prebuilt
# static libs exist at v1.13.4. Download them and point the build at
# the extracted directory via SHERPA_ONNX_LIB_DIR.
# sherpa-onnx-sys doesn't auto-detect win-x86, so download the
# prebuilt static libs for the pinned crate version and point the
# build at them via SHERPA_ONNX_LIB_DIR.
#
# KEEP IN SYNC with the exact `sherpa-onnx` pin in Cargo.toml:
# builds resolve fresh (Cargo.lock is gitignored and the version
# job rewrites Cargo.toml), so a version mismatch means either a
# compile error (crate/sys pair drift) or LNK2019 (crate newer
# than the lib, e.g. 1.13.5's SherpaOnnxGetOnnxruntimeVersionStr
# missing from the 1.13.4 lib).
if: matrix.target == 'i686-pc-windows-msvc'
shell: pwsh
run: |
$url = "https://github.com/k2-fsa/sherpa-onnx/releases/download/v1.13.4/sherpa-onnx-v1.13.4-win-x86-static-MD-Release-lib.tar.bz2"
$url = "https://github.com/k2-fsa/sherpa-onnx/releases/download/v1.13.5/sherpa-onnx-v1.13.5-win-x86-static-MD-Release-lib.tar.bz2"
Invoke-WebRequest -Uri $url -OutFile sherpa-x86.tar.bz2
mkdir sherpa-x86-libs | Out-Null
tar -xjf sherpa-x86.tar.bz2 -C sherpa-x86-libs --strip-components=1
Expand Down
7 changes: 6 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,12 @@ display_names = ["dep:icu_displaynames", "dep:icu_locid"]
reqwest = { version = "0.12", features = ["blocking", "json", "rustls-tls"], default-features = false, optional = true }
serde = { version = "1", features = ["derive"] }
serde_json = { version = "1", optional = true }
sherpa-onnx = { version = "1.13", optional = true }
# Exact pin: the i686-windows publish job links a prebuilt static lib
# downloaded from the k2-fsa release of THIS version (see publish.yml
# "Download sherpa-onnx x86 prebuilt"). A minor drift (crate 1.13.4 with
# sys 1.13.5 doesn't even compile, and a newer crate references C-API
# symbols an older prebuilt lib lacks → LNK2019). Bump both together.
sherpa-onnx = { version = "=1.13.5", optional = true }
base64 = { version = "0.22", optional = true }
speechmarkdown-rust = { version = "0.4.12", optional = true }
anyhow = "1"
Expand Down
Loading