fix(publish): exact-pin sherpa-onnx 1.13.5 + matching win-x86 prebuilt - #17
Merged
Conversation
The i686-windows release build failed with LNK2019: unresolved _SherpaOnnxGetOnnxruntimeVersionStr. Cargo.lock is gitignored and the version job rewrites Cargo.toml, so every release build resolves dependencies fresh — sherpa-onnx drifted to 1.13.5 while the i686 workaround still downloaded the v1.13.4 win-x86 static lib, whose C-API lacks that symbol (verified: 3 occurrences in the 1.13.5 archive's sherpa-onnx-c-api.lib, 0 in 1.13.4's). Also, an exact 1.13.4 pin is not viable: sherpa-onnx 1.13.4 does not compile against sherpa-onnx-sys 1.13.5 (upstream doesn't pin its own sys dep; OfflineSpeechDenoiserDpdfNetModelConfig gained a field), so the only consistent fresh resolution is a matched pair. - Cargo.toml: sherpa-onnx = "=1.13.5" with a KEEP-IN-SYNC note - publish.yml: download v1.13.5 win-x86 static libs; comments explain both failure modes of drift (compile error, LNK2019) Verified locally: fresh lock resolves 1.13.5/1.13.5, release build ok, 178 lib tests green, live sherpa suite green except the two tests whose matcha model isn't downloaded locally (CI fetches it).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The v0.3.17 release's i686-windows job failed:
LNK2019: unresolved external symbol _SherpaOnnxGetOnnxruntimeVersionStr.Two compounding causes, both verified:
Cargo.lockis gitignored and theversionjob sed-rewritesCargo.toml, so the matrix builds lock from scratch. sherpa-onnx had drifted to 1.13.5 since the workaround was written.sherpa-onnx-c-api.liblacksSherpaOnnxGetOnnxruntimeVersionStr(0 occurrences; the v1.13.5 archive has 3 — checked directly in the COFF archives).What
sherpa-onnx = "=1.13.5"exact pin — note that pinning to 1.13.4 is not an option: sherpa-onnx 1.13.4 doesn't compile against sherpa-onnx-sys 1.13.5 (upstream leaves its own sys dep on1.13; a struct gained a field), so the only consistent fresh resolution is a matched pairTesting
After merge: re-tag v0.3.17 on the merge commit to re-run the release.