Skip to content

Remove broken badge#4121

Open
DimitriPapadopoulos wants to merge 2 commits into
zarr-developers:mainfrom
DimitriPapadopoulos:Build_Status
Open

Remove broken badge#4121
DimitriPapadopoulos wants to merge 2 commits into
zarr-developers:mainfrom
DimitriPapadopoulos:Build_Status

Conversation

@DimitriPapadopoulos

Copy link
Copy Markdown
Contributor

Summary

It relies on a CI workflow (.github/workflows/python-package.yml) that had been removed in 2024 by 9e3e8c0.

It's unclear whether it should be replaced by a different CI workflow, and if so which one.

For reviewers

Would you rather replace with a different workflow? Which one?

Author attestation

  • I am a human, these are my changes, and I have reviewed and understood every change and can explain why each is correct.

AI coding assistance is welcome, but a human must be the author and is responsible for the contents of the PR. The description and any review responses must be in your own words. Please read AI-assisted contributions before opening.

TODO

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.md
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions Bot added the needs release notes Automatically applied to PRs which haven't added release notes label Jul 6, 2026
@d-v-b

d-v-b commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

what is the point of this badge? just conveying that tests are passing? maybe this workflow is right for that: https://github.com/zarr-developers/zarr-python/actions/workflows/test.yml

@d-v-b

d-v-b commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

and if you have the patience for it, we could do a horizontal layout for these badges to save space. See the example from pydantic's readme

@DimitriPapadopoulos

Copy link
Copy Markdown
Contributor Author

It did convey that the .github/workflows/python-package.yml workflow, combining liniting, testing and building was passing. If you ask me, it's best to get rid of it.

OK for the horizontal layout.

@d-v-b

d-v-b commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

If you ask me, it's best to get rid of it.

👍

@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as draft July 6, 2026 11:19
It relies on a CI workflow that had been removed in 2024 by 9e3e8c0.

It's unclear whether it should be replaced by a different CI workflow,
and if so which one.
@DimitriPapadopoulos

DimitriPapadopoulos commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Changes as follows:

  • Latest Release - kept as is
  • (Conda) latest release CondaForge
  • Package Status - kept as is
  • License - kept as is
  • Build Status - removed
  • Pre-commit Status - removed
  • Coverage - kept as is
  • Downloads - kept as is
  • Developer Chat - kept as is
  • Funding - kept as is
  • Citation - kept as is

I have removed the first column of the vertical tabular layout, as it doesn't fit the horizontal layout, doesn't convey crucial or new information, and is not standard (badges shouldn't need an explanation or title).

The line remains a bit long, despite I removed 2 badges. How do you like it?

@DimitriPapadopoulos DimitriPapadopoulos force-pushed the Build_Status branch 2 times, most recently from ca75df4 to c9529ad Compare July 6, 2026 12:01
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review July 6, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs release notes Automatically applied to PRs which haven't added release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants