chore: sync react localization from platform-localization#274
Open
platform-localization-pr-bot[bot] wants to merge 1 commit into
Open
chore: sync react localization from platform-localization#274platform-localization-pr-bot[bot] wants to merge 1 commit into
platform-localization-pr-bot[bot] wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated localization sync from
platform-localization.4fa6992cc909a1115d57ce53d4f0af76ef230692Distribute React LocalizationGreptile Summary
This automated PR removes two duplicate localization keys (
noLanguageSearchResultsandlanguageSearchAriaLabel) fromen.json, where they previously appeared both near the top of the file and again around line 45. The keys are retained at their original position (lines 4–5) and all component references remain intact.noLanguageSearchResultsandlanguageSearchAriaLabelwere duplicated in the JSON file; only the second (lower) occurrence is removed, so the values are unchanged.bible-version-picker.tsxuses both keys viat()and will continue to resolve them correctly from the remaining entry.Confidence Score: 5/5
Safe to merge — the change removes duplicate JSON keys that were already present earlier in the file, leaving all translation strings and component references intact.
The only changed file is
en.json, and the two removed entries (noLanguageSearchResults,languageSearchAriaLabel) still exist at the top of the file. The consuming componentbible-version-picker.tsxresolves both keys correctly from the retained entries, so no runtime behavior changes.No files require special attention.
Important Files Changed
noLanguageSearchResultsandlanguageSearchAriaLabel; both keys remain at the top of the file and all component references are unaffected.Sequence Diagram
%%{init: {'theme': 'neutral'}}%% sequenceDiagram participant PL as platform-localization participant Bot as pr-bot[bot] participant SDK as platform-sdk-react participant JSON as en.json participant Comp as bible-version-picker.tsx PL->>Bot: Trigger "Distribute React Localization" workflow Bot->>SDK: Open PR with synced en.json Note over JSON: Remove duplicate keys at line ~45<br/>(noLanguageSearchResults, languageSearchAriaLabel)<br/>Keys still present at lines 4-5 SDK-->>JSON: Apply diff (dedup) Comp->>JSON: t('noLanguageSearchResults') → still resolved ✓ Comp->>JSON: t('languageSearchAriaLabel') → still resolved ✓%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%% sequenceDiagram participant PL as platform-localization participant Bot as pr-bot[bot] participant SDK as platform-sdk-react participant JSON as en.json participant Comp as bible-version-picker.tsx PL->>Bot: Trigger "Distribute React Localization" workflow Bot->>SDK: Open PR with synced en.json Note over JSON: Remove duplicate keys at line ~45<br/>(noLanguageSearchResults, languageSearchAriaLabel)<br/>Keys still present at lines 4-5 SDK-->>JSON: Apply diff (dedup) Comp->>JSON: t('noLanguageSearchResults') → still resolved ✓ Comp->>JSON: t('languageSearchAriaLabel') → still resolved ✓Reviews (1): Last reviewed commit: "chore: sync react localization" | Re-trigger Greptile