Segregate the methods of the AuthenticationMethodInterface#114
Segregate the methods of the AuthenticationMethodInterface#114klsoft-web wants to merge 1 commit into
Conversation
klsoft-web
commented
Jul 24, 2026
klsoft-web
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Fixed issues | #113 |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #114 +/- ##
============================================
- Coverage 95.87% 95.26% -0.62%
+ Complexity 77 76 -1
============================================
Files 10 10
Lines 194 190 -4
============================================
- Hits 186 181 -5
- Misses 8 9 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| public function __construct( | ||
| private AuthenticationMethodInterface $authenticationMethod, | ||
| ResponseFactoryInterface $responseFactory, | ||
| ?RequestHandlerInterface $authenticationFailureHandler = null, | ||
| ) { | ||
| $this->failureHandler = $authenticationFailureHandler ?? new AuthenticationFailureHandler( | ||
| $responseFactory, | ||
| ); | ||
| } | ||
| private AuthenticatorInterface $authenticator, | ||
| private RequestHandlerInterface $authenticationFailureHandler, | ||
| ) {} |
There was a problem hiding this comment.
That is a backward compatibility break.
There was a problem hiding this comment.
It's exactly the same code that was approved for the issue. Has something changed?
| * ``` | ||
| */ | ||
| final class HttpBasic implements AuthenticationMethodInterface | ||
| final class HttpBasic implements AuthenticatorInterface, ChallengeInterface |
There was a problem hiding this comment.
That should be capped for this release.
| * Composite allows multiple authentication methods at the same time. | ||
| */ | ||
| final class Composite implements AuthenticationMethodInterface | ||
| final class Composite implements AuthenticatorInterface, ChallengeInterface |
There was a problem hiding this comment.
Should be kept for this release.
| * @see https://tools.ietf.org/html/rfc6265 | ||
| */ | ||
| final class HttpCookie implements AuthenticationMethodInterface | ||
| final class HttpCookie implements AuthenticatorInterface |
There was a problem hiding this comment.
Should be kept for this release.
2 participants
