Skip to content

fix: render correct font on Default font label#1264

Merged
briantstephan merged 2 commits into
mainfrom
default-font-label
Jul 13, 2026
Merged

fix: render correct font on Default font label#1264
briantstephan merged 2 commits into
mainfrom
default-font-label

Conversation

@briantstephan

Copy link
Copy Markdown
Contributor

When switching from the "Default" font option to a different font, and then back to Default, the label for "Default" in the props menu would continue rendering with the previously selected font, even though that font was no longer getting used. This fixes that issue.

This screenshot shows the issue as it was before, which is now fixed.
Screenshot 2026-07-10 at 5 31 24 PM

@briantstephan briantstephan self-assigned this Jul 10, 2026
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 77b33404-c275-4673-8354-96b065ef10ee

📥 Commits

Reviewing files that changed from the base of the PR and between 8eca4e9 and c88ed4f.

📒 Files selected for processing (1)
  • packages/visual-editor/src/internal/puck/components/FontSelector.tsx

Walkthrough

FontSelector now converts the "default" font option to undefined before applying preview fontFamily styles to the selected trigger and font options. Its onChange callback prop now accepts a string value instead of any.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main fix: rendering the correct font for the Default label.
Description check ✅ Passed The description matches the change by explaining the Default font label rendering issue and its fix.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch default-font-label

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@briantstephan briantstephan merged commit a46fa45 into main Jul 13, 2026
17 checks passed
@briantstephan briantstephan deleted the default-font-label branch July 13, 2026 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants