CI runs the Go tests under the race detector - #78
Merged
Conversation
The alerter and agent code is deliberately concurrent, and the review rounds that shaped it left behind a suite of tests that pin contested interleavings with barrier hooks. Those tests only earn their keep if the race detector is watching while they run, so the CI test step now passes -race. It also passes -count=1: actions/setup-go restores the Go build cache between runs, and a cached test result silently replays the old pass instead of executing anything. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NpxQtrW7f2YaKiYL6evoTZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Go/C CI itself already exists (
.github/workflows/build.yml: configure + make +make checkfor sysmond, vet/test/build/install-staging for sysmon-web, and a Tailwind staleness check), so the follow-up from the review wrap-up reduces to one gap: the Go test step ran without the race detector.The alerter and agent code is deliberately concurrent, and the review rounds left behind tests that pin contested interleavings (reconnect ordering, revoke during handshake, stale-producer commits, concurrent mints) with barrier hooks. Those only earn their keep if
-raceis watching while they run. The step also gains-count=1: actions/setup-go restores the Go build cache between runs, and a cached test result silently replays the old pass instead of executing anything.Verified locally:
go test -race -count=1 ./...passes across all packages.🤖 Generated with Claude Code
https://claude.ai/code/session_01NpxQtrW7f2YaKiYL6evoTZ
Generated by Claude Code
Note
Overview
CI now runs the sysmon-web Go suite with the race detector so concurrent alerter/agent tests actually catch data races.
The test step also uses
-count=1so a restored Go build cache cannot skip execution by replaying a previous pass.Reviewed by Cursor Bugbot for commit cd52450. Bugbot is set up for automated code reviews on this repo. Configure here.