closes 248 - #261
Merged
Merged
Conversation
Contributor
|
@evanjain-dot is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
yakew7
added a commit
that referenced
this pull request
Aug 14, 2026
Bump the snapshot to cover #256, #258, #259, #260, #261 - five PRs merged since the last update (#238). Corrects ahmdkaml's merged-PR count from 30 to 36 (the previous count undercounted due to gh pr list's default 30-item page limit) and adds their #256/#258/#259 work. Credits evanjain-dot's ruff-linter PR (#261, closes #248) and propcgamer20-png's report.py table-accessibility PR (#260, closes #254), and adds propcgamer20-png to the Profiler - CLI & loaders area row for touching faircode/report.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved issue - closes #248
Add ruff check as a Python linter, scoped to select = ["F"] (Pyflakes
only: unused imports, undefined names, redefinitions) in
pyproject.toml - narrower than ruff's own default (E4, E7, E9, F).
E4 includes E402, which false-positives on tests/*.py's
pytest.importorskip(...) then from x import y guard idiom (used in
test_metrics.py, test_proxy.py, test_strategies.py, and elsewhere);
flagging that would be exactly the style churn the issue asked to
avoid.
Wired into make lint/lint.yml (added the pip install ruff step it
needed), .pre-commit-config.yaml (mirroring the em-dash hook's
always_run/pass_filenames style, per the issue's suggestion), and
make setup's installed dev tools.
Running it found two real bugs, both fixed: a duplicated
"import importlib" in tests/test_generate_images.py, and an unused
Manifest import in tests/test_manifest.py.