Skip to content

Fix direct push workflows - #259

Merged
yakew7 merged 3 commits into
yakew7:mainfrom
ahmdkaml:fix-direct-push-workflows
Aug 14, 2026
Merged

Fix direct push workflows#259
yakew7 merged 3 commits into
yakew7:mainfrom
ahmdkaml:fix-direct-push-workflows

Conversation

@ahmdkaml

Copy link
Copy Markdown
Collaborator

Make the frozen-file and Build Explainers checks run on direct pushes to main, while keeping their existing PR behavior and path filtering.

I initially missed that both workflows relied on PR-specific event fields. The first version therefore failed on direct pushes; this updates the frozen-file check to handle both event types correctly.

Also pins Pillow to the frozen 11.1.0 version to keep OG image generation deterministic.

Closes #246

not sure if this will clear all the CI complaints

@ahmdkaml
ahmdkaml requested a review from yakew7 as a code owner August 14, 2026 12:54
@vercel

vercel Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

@ahmdkaml is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

Copy link
Copy Markdown

@yakew7 - new PR to review.

@yakew7
yakew7 merged commit d60abe9 into yakew7:main Aug 14, 2026
17 of 18 checks passed
yakew7 added a commit that referenced this pull request Aug 14, 2026
Bump the snapshot to cover #256, #258, #259, #260, #261 - five PRs
merged since the last update (#238). Corrects ahmdkaml's merged-PR
count from 30 to 36 (the previous count undercounted due to gh pr
list's default 30-item page limit) and adds their #256/#258/#259
work. Credits evanjain-dot's ruff-linter PR (#261, closes #248) and
propcgamer20-png's report.py table-accessibility PR (#260, closes
#254), and adds propcgamer20-png to the Profiler - CLI & loaders area
row for touching faircode/report.py.
yakew7 added a commit that referenced this pull request Aug 14, 2026
CHANGELOG.md was missing entries for two ahmdkaml PRs that landed
today: #258/#259 (closes #246, frozen-files/build-explainers now run
on direct pushes to main, not just PRs) and #256 (closes #255,
restores tests/test_dependency_versions.py and fixes the scikit-learn
drift it caught instead of leaving it deleted). Also added PR-author
credit to the existing #248/#254 entries now that it's known who
actually submitted those PRs (evanjain-dot, propcgamer20-png).

METRICS.md: stars 42 -> 43 (verified live via the GitHub API; forks,
watching, and contributors confirmed unchanged the same way - the
contributors badge's 14 already matched the API's 16 total minus the
2 bot accounts). Added a "2026-W33 (later in week)" narrative note
summarizing the day's batch, matching the doc's existing convention
for multiple same-week updates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build Explainers and Frozen Files workflows only trigger on pull_request, so they don't run at all on a direct push to main

2 participants