test locked dependency versions against minimums - #256
Merged
Conversation
Contributor
|
@ahmdkaml is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@yakew7 - new PR to review. |
yakew7
added a commit
that referenced
this pull request
Aug 14, 2026
#235 declared matplotlib>=3.11 in pyproject.toml's benchmark extra, copied from requirements.txt without checking it against requirements-lock.txt - which has matplotlib==3.10.9. #256's restored tests/test_dependency_versions.py (fixing #255's scikit-learn drift) caught this same drift for matplotlib once both landed on main. Lower the declared floor to >=3.10 to match what's actually locked, same fix pattern as #256's scikit-learn change.
yakew7
added a commit
that referenced
this pull request
Aug 14, 2026
Bump the snapshot to cover #256, #258, #259, #260, #261 - five PRs merged since the last update (#238). Corrects ahmdkaml's merged-PR count from 30 to 36 (the previous count undercounted due to gh pr list's default 30-item page limit) and adds their #256/#258/#259 work. Credits evanjain-dot's ruff-linter PR (#261, closes #248) and propcgamer20-png's report.py table-accessibility PR (#260, closes #254), and adds propcgamer20-png to the Profiler - CLI & loaders area row for touching faircode/report.py.
yakew7
added a commit
that referenced
this pull request
Aug 14, 2026
CHANGELOG.md was missing entries for two ahmdkaml PRs that landed today: #258/#259 (closes #246, frozen-files/build-explainers now run on direct pushes to main, not just PRs) and #256 (closes #255, restores tests/test_dependency_versions.py and fixes the scikit-learn drift it caught instead of leaving it deleted). Also added PR-author credit to the existing #248/#254 entries now that it's known who actually submitted those PRs (evanjain-dot, propcgamer20-png). METRICS.md: stars 42 -> 43 (verified live via the GitHub API; forks, watching, and contributors confirmed unchanged the same way - the contributors badge's 14 already matched the API's 16 total minus the 2 bot accounts). Added a "2026-W33 (later in week)" narrative note summarizing the day's batch, matching the doc's existing convention for multiple same-week updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the dependency-version consistency test from #215 and resolves the drift it detects.
tests/test_dependency_versions.pypyproject.tomlminimumsscikit-learnminimum from1.9.0to1.8.0to match the frozen lock fileThe frozen
requirements-lock.txtis left unchanged.Closes #255