The -o help text promises a generated error page the engine never builds#803
Merged
Conversation
`-o` only decides whether the error page the server sent survives: `store_errpage` keeps `r.adr` alive so the normal save path writes it, and the `-o0` arm frees it. Nothing anywhere builds a stand-in body. The one block that would have was dead since the 3.20.2 import and was removed in #783. Reword the help line, the man page and fcguide's two `-o` prose blocks to say the server's error page is saved rather than generated, and extend 23_local-errpage so the mirrored 404 has to carry the server's own body. Closes #787 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <xroche@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-onever generated anything. It only decides whether the error page the server sent survives:htsparse.csetsstore_errpageso the normal save path writesr.adr, and the-o0arm frees it instead. The block that would have built a stand-in body was dead since the 3.20.2 import and went away in #783. A crawl against the test server's 404 settles it: under-o1the mirrored file is the server's body verbatim, with no HTTrack footer, and under-o0there is no file at all.The doc side is therefore the wrong one. The help line, the regenerated man page and its html render, fcguide's four copies of the option line and its two prose blocks, and the matching sentence in
html/step9_opt5.htmlnow say the server's error page is saved rather than generated. The--generate-errors/--do-not-generate-errorsaliases and the GUI labels inlang/*.txt("No error pages", "Do not create HTML error pages", 30 files) keep their wording: renaming a CLI alias breaks scripts, and re-translating 30 files for one word is not worth it.23_local-errpage.testnow asserts the mirrored 404 holds the server's own body and does not hold "HTTrack", which makes the corrected wording a tested claim. A third assertion checks thatgood.htmldoes hold "HTTrack" from its footer, so the negative is not vacuous; inverting it fails the test.Closes #787