Sitemap GUI strings are untranslated outside English and Francais#738
Open
xroche wants to merge 1 commit into
Open
Sitemap GUI strings are untranslated outside English and Francais#738xroche wants to merge 1 commit into
xroche wants to merge 1 commit into
Conversation
The feature PR added the four LANG_SITEMAP* entries to lang.def with English and Francais only; every other locale fell back to English in the WebHTTrack form. Each file is written in its own declared charset. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sitemap options landed in lang.def with English and Francais filled in, so the WebHTTrack form showed the English string in the other 28 locales. This fills those in.
Data only: four msgid/translation pairs appended per file, no deletions. Each file is written in its own declared charset rather than UTF-8, which is where the traps are. Svenska declares ISO-8859-2 but actually stores Latin-1, Chinese-BIG5 means Windows BIG5 (cp950), Uzbek is LF-terminated where the other 29 files are CRLF, and Romanian and Slovenian declare ISO-8859-1, which cannot carry their diacritics, so those fold to base letters the same way the existing content in those files already does.
Checked deterministically rather than by eye: every file still decodes in its own charset, the msgid/translation pairing stays even, the join keys are byte-identical ASCII, EOLs are uniform per file, and
tests/62_lang-integrity.testpasses. I also confirmed that test fails on a deliberately drifted msgid, so its pass means something. Translations are best effort; a native speaker is the real quality gate.Stacked on
feat/sitemapbecause test 62 requires every msgid to exist in English.txt, and only that branch has these.