Give the Add/Remove Programs entry an icon#67
Merged
Conversation
Add/Remove Programs shows whatever the uninstall key's DisplayIcon points at, and only UninstallDisplayIcon writes it. The installer set SetupIconFile and UninstallIconFile, which cover setup.exe and the uninstaller stub, so the product entry itself was left with no icon. Point it at the installed WinHTTrack.exe, which already carries the icon. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019HXNEMWtyrkW7xoD8ewcR3 Signed-off-by: Xavier Roche <roche@httrack.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add/Remove Programs shows whatever the uninstall key
DisplayIconpoints at, and onlyUninstallDisplayIconwrites it. The installer setSetupIconFileandUninstallIconFile, which coversetup.exeand the uninstaller stub respectively, so the product entry itself had none.Points it at the installed
WinHTTrack.exe, which already carries the icon, so no extra file ships.Reported from VM testing.