Bound the language-name copy in LANG_LOAD#66
Merged
Conversation
limit_to is a bare char*, and the buff() macros only carry a bound when the destination is a sized array: for a pointer they silently degrade to plain strcpy. Callers pass a 1024-byte buffer while a lang.def name value can be far longer, so a long enough entry overflowed the caller's stack. Take the capacity from the caller and truncate with lstrcpynA, which always terminates. Truncation rather than an abort, since this is a display name, and an empty name stays empty so the enumeration terminator is unaffected. Pre-existing; the copy was unbounded before the placeholder was ever added. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019HXNEMWtyrkW7xoD8ewcR3 Signed-off-by: Xavier Roche <roche@httrack.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019HXNEMWtyrkW7xoD8ewcR3 Signed-off-by: Xavier Roche <roche@httrack.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Callers pass a 1024-byte buffer, and a
lang.defname value can be longer, so a long enough entry overflowed the caller stack. The copy looked bounds-checked but was not; the reason is in the comment at the call.The capacity now comes from the caller and the copy goes through
lstrcpynA, which always terminates. Truncation rather than an abort, since this is a display name; an empty name still stays empty, so the enumeration terminator #64 restored is unaffected.Pre-existing, and found by an adversarial reviewer on #64.