Surface the sitemap, single-file and change-report options in the GUI - #77
Merged
Conversation
The engine gained --sitemap, --single-file and --changes; bump the vendored snapshot to core master and put a checkbox on each of the tabs the reference GUI uses (Spider, Build, Log/Index/Cache). The three go out as their own argv token rather than packed into the compacted -%… string: -%m and -%Z each have a two-letter variant (-%mu, -%Zs), and the engine scans that string one character at a time, so a neighbouring flag's first letter would be read as the variant and swallow an argument. Android.mk lists engine sources explicitly, so the bump also has to register htssitemap.c, htssinglefile.c, htschanges.c and htscmdline.c. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0163vUGoRjjxBmt67HhHQ7ps Signed-off-by: Xavier Roche <roche@httrack.com>
The pair of tests passed against three broken emitters: one ignoring its constructor argument, one also packing into the flag string (guarded on a non-empty buffer, which the empty test fixture never tripped), and one emitting only on the first call. Assert every token, seed the buffer the way buildCommandline() does, and emit twice, since the mappers are static singletons. All three mutations now fail the suite. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0163vUGoRjjxBmt67HhHQ7ps Signed-off-by: Xavier Roche <roche@httrack.com>
This was referenced Jul 27, 2026
xroche
added a commit
that referenced
this pull request
Jul 27, 2026
Ships the sitemap, single-file and change-report options (#77). Engine HTTRACK_VERSIONID is still 3.49.14, so only the last part moves. Claude-Session: https://claude.ai/code/session_0163vUGoRjjxBmt67HhHQ7ps Signed-off-by: Xavier Roche <roche@httrack.com> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine gained
--sitemap,--single-fileand--changes. This bumps the vendored snapshot to core master and adds a checkbox for each, on the same tab the reference GUI uses: Spider, Build, Log/Index/Cache.The three go out as their own argv token instead of being packed into the compacted
-%…string, unlike every other boolean here.-%mand-%Zeach have a two-letter variant (-%mutakes a URL,-%Zstakes a size), and the engine reads the packed string one character at a time, so the next flag's first letter would be taken for that variant and swallow an argument. On Spider the neighbour is-u, on Build it is-s.Android.mklists engine sources by hand, so the bump also registershtssitemap.c,htssinglefile.c,htschanges.candhtscmdline.c. The last one came with an unrelated core change and would have broken the link by itself, confirmed by symbol-checkinglibhttrack.so.The tests cover the emitter and were checked against three broken versions of it. The table wiring behind it has no test seam, because
android.util.Pairin the static tables throws under the stubandroid.jar, so that part rests on the build and on trying the checkboxes.