Drop the removed Java .class parser from the About-box credits - #70
Merged
Conversation
The engine deleted its Java .class parser in httrack#552; xroche/httrack#691 finally drops the stale "JavaParserClasses: Yann Philippot" line from the credits block (LANG_K1 and every translation). Mirror that here in the app's hand-maintained about_credits string so the About box matches upstream. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
xroche
added a commit
that referenced
this pull request
Jul 24, 2026
Ship the two changes sitting on master since vc80: the doc-index license.txt and history.txt bundling (#69) and the dropped Java .class parser credit (#70). Engine stays at 3.49.14, so the versionName prefix is unchanged and Android.mk is untouched. Signed-off-by: Xavier Roche <roche@httrack.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The About box still credited a Java
.classparser the engine removed years ago (httrack#552). xroche/httrack#691 dropped that line from the engine credits; this mirrors it in the app's hand-maintainedabout_creditsstring. That one string is the only copy in the repo, so it's the whole change.