Skip to content

Fix pydantic issues that raise errors in validation - #12

Draft
MitchellAV wants to merge 2 commits into
xopt-org:mainfrom
MitchellAV:fix/pydantic
Draft

Fix pydantic issues that raise errors in validation#12
MitchellAV wants to merge 2 commits into
xopt-org:mainfrom
MitchellAV:fix/pydantic

Conversation

@MitchellAV

Copy link
Copy Markdown

Active PR for fixing various pydantic issues

  • each pydantic class should have a name field which uses the Field class with frozen=True
  • should field should have proper defaults with correct typing
    i.e. field of str should not have a default of None, etc...
  • abstract methods from base classes need to have consistent argument ordering

more to be found...

run against mypy --strict to identify each pydantic issue

@MitchellAV

Copy link
Copy Markdown
Author

@dylanmkennedy Fixes are still required before bax visualizer extension is useable.

  • still in draft until fixed
  • update pypi once all validation and testing has been confirmed locally to be fixed in badger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant