fix: make React Native test failures fail the CI check - #776
Draft
JuliocesarsantosTI wants to merge 4 commits into
Draft
fix: make React Native test failures fail the CI check#776JuliocesarsantosTI wants to merge 4 commits into
JuliocesarsantosTI wants to merge 4 commits into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #709
What was wrong
While looking through the React Native E2E flow, I noticed the CI could report success before the full test run had actually finished.
The completion marker was available too early, and the flow was checking that a FAIL marker was not visible instead of positively confirming that the whole suite finished successfully.
What I changed
I did not touch the shipped SDK code under src/.
Testing
I validated the parts I could run locally:
I could not run the native E2E flow locally because I do not have an Android emulator / macOS simulator setup available, so the first CI run on this PR will be the first full native execution of the updated flow.
Notes
The exact runtime of the full suite may need some timeout tuning once there is real CI data.
Branch protection / required-check configuration still needs to be handled by a maintainer, and I did not add automatic flaky-test issue creation because I did not want to introduce noisy or unreliable behavior.
Checklist
Note
Fix React Native CI to fail on test failures
tests-passedandtests-failedelements with accessibility labels to TestScreen.tsx, giving the Maestro flow a machine-readable pass/fail signaltests-passed(failing the run if tests fail), extends the wait timeout to 40 minutes, and captures a summary screenshotMacroscope summarized a41cb61.