Fix publish counts - #577
Merged
Merged
Conversation
ce10-sanger
force-pushed
the
NPG-4028-publish-counts
branch
from
July 22, 2026 14:13
8cb7f91 to
51cfa3c
Compare
mksanger
reviewed
Jul 22, 2026
|
|
||
| from pathlib import Path | ||
| from pathlib import Path, PurePath | ||
| from unittest.mock import MagicMock, patch |
Contributor
There was a problem hiding this comment.
Why are you mocking this rather than just publishing a directory?
Contributor
Author
There was a problem hiding this comment.
Unit testing publish_result_dirs rather than integration testing the publish_result_dirs > publish_result_dir > partisan > baton > irods stack to achieve a smaller/narrower test
Contributor
Author
|
Cheers for the review @mksanger |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publish success and failure counts were only being updated when flags to output paths were enabled. Fix and test.