Rework post-handshake checks for resumed connections. - #11198
Open
kareem-wolfssl wants to merge 2 commits into
Open
Rework post-handshake checks for resumed connections.#11198kareem-wolfssl wants to merge 2 commits into
kareem-wolfssl wants to merge 2 commits into
Conversation
kareem-wolfssl
requested review from
Frauschi
and
a balanced review from Copilot
August 18, 2026 19:16
Contributor
There was a problem hiding this comment.
Pull request overview
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Reworks TLS 1.3 post-handshake authentication (PHA) validation so that resumed (ticket/PSK) connections still enforce required certificate/verify checks during post-handshake exchanges, and adds regression tests for the updated behavior.
Changes:
- Add new TLS 1.3 PHA tests covering resumption and a “bare Finished” negative case.
- Introduce a helper macro to identify post-handshake processing and use it to tighten/relax TLS 1.3 sanity checks appropriately.
- Ensure client Certificate/CertificateVerify sending and server Finished validation behave correctly for post-handshake flows on resumed connections.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| tests/api/test_tls13.h | Registers two new TLS 1.3 PHA+resumption test cases in the test list. |
| tests/api/test_tls13.c | Implements two new regression tests for PHA on resumption and rejecting an invalid post-handshake Finished. |
| src/tls13.c | Adjusts TLS 1.3 Finished/sanity logic to distinguish post-handshake exchanges from the main handshake, including PSK/resumption cases. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
Confirmed—this fixes the issue. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes zd#22349
Testing
Built in tests
Checklist