Clear up QUIC previous read encryption level(s) in wolfSSL_quic_clear() - #11196
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes QUIC/TLS connection reuse by ensuring wolfSSL_clear() fully resets QUIC encryption-level tracking state via wolfSSL_quic_clear(), preventing stale read/write level state from incorrectly affecting subsequent connections on the same WOLFSSL*.
Changes:
- Reset the remaining QUIC encryption-level fields (
enc_level_{read,read_next,write_next}) inwolfSSL_quic_clear(), bringing QUIC state back to the same baseline as a fresh QUICWOLFSSL*. - Add a regression test that performs a full QUIC handshake, calls
wolfSSL_clear(), and verifies the client’s QUIC read/write levels return towolfssl_encryption_initialand that Initial-level data is accepted again.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/quic.c | Resets all QUIC encryption-level fields during wolfSSL_quic_clear() so reuse via wolfSSL_clear() starts from Initial state. |
| tests/quic.c | Adds test_quic_clear_reuse to validate QUIC state reset behavior after wolfSSL_clear(). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
79f4326 to
865139b
Compare
|
retest this please |
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11196
Scan targets checked: wolfssl-bugs, wolfssl-src
Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
philljj
left a comment
There was a problem hiding this comment.
Looks good, just small suggested test change.
… up a TLS connection
865139b to
9dda3b8
Compare
|
Jenkins retest this please. |
Description
Reset all five encryption-level in wolfSSL_quic_clear() when cleaning up a TLS connection
Testing
Added a regression test
test_quic_clear_reuse.Checklist