Make SE05x SCP03-only builds slimmer - #356
Open
LinuxJedi wants to merge 3 commits into
Open
Conversation
SCP03-only builds only need AES-CBC, AES-CMAC and RNG. This path reduces those builds to those algorithms. In testing on our Docker builds this reduced the binary from 423K to 165K.
The wolfSSL HostCrypto adapter declared and implemented sss_wolfssl_generate_ecc_key unconditionally. Removing HAVE_ECC from a minimal SE05x build therefore left the adapter referencing unavailable curve identifiers and wolfCrypt ECC APIs. Guard the declaration, classic ECC key-generation cases, and implementation with HAVE_ECC in both the SE05x middleware v04.02.00 and v04.07.01 patches. Keep the independently configured Montgomery and EdDSA cases available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SCP03-only builds only need AES-CBC, AES-CMAC and RNG. This path reduces those builds to those algorithms. In testing on our Docker builds this reduced the binary from 423K to 165K.