Name the method in CSVKitUtility.main's NotImplementedError - #1350
Merged
jpmckinney merged 1 commit intoJul 23, 2026
Merged
Conversation
The message started with a stray space and omitted the method name, raising ' must be provided by each subclass of CSVKitUtility.' The sibling add_arguments names itself; do the same for main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSVKitUtility.mainraises aNotImplementedErrorwhose message is missing the method name and begins with a stray space:So a subclass author who forgets to implement
main()gets:The sibling
add_argumentsa few lines above names itself correctly, which shows the intended form:This adds the missing
mainso both messages match.No CHANGELOG entry, since this is an internal error message rather than a user-facing script change — happy to add one if you'd prefer.
tests/test_cli.pypasses locally andflake8is clean.