chore: correct BACKLOG - attachments already wired, unknown-request fallback exists - #63
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two corrections to the 0.16.3 audit landed in #62, found while evaluating whether to implement the new interfaces:
attachmentsis not unwired — the bridge already extracts ACP image content blocks (extractAttachments) and forwards them onsession/send(localPathforfile://uris,dataBase64otherwise). Moved out of the unwired list; the genuinely unwiredsession/sendparams (toolDenylist,runtimeModel,browserAmbientContext, …) stay listed.server-requests.tshandleOnerepliesbridge unsupported: <method>to any unrecognized request during a turn, andsession/sendcarries a 15s timeout, soworkspace/hooks/trustGrant/interaction/browser*/requestProviderRuntimeHeaderscannot hang a turn. The "could hang — watch for this" warning was overstated and is replaced with the actual behavior, plus a note on mapping hook trust to ACPsession/request_permissionif real UX is ever needed.Docs-only; no behavior change, no version bump.