Skip to content

fix: add numeric keypad hints for weight and repetitions fields on mobile #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolandgeider merged 4 commits into from
Jul 9, 2026
Merged

fix: add numeric keypad hints for weight and repetitions fields on mobile #1273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
50d5ebe
fix: add numeric keypad hints for weight and repetitions fields on mo…
Mehak-mahajan Jul 2, 2026
8deac95
fix: add decimal inputMode to all numeric input fields for mobile key…
Mehak-mahajan Jul 3, 2026
fce4190
fix: correct syntax and add inputMode to all numeric fields
Mehak-mahajan Jul 7, 2026
28dc434
The label and ID for the field is "notes", not "value", fix indentation
rolandgeider Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Measurements/widgets/EntryForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ export const EntryForm = ({ entry, closeFn, categoryId }: EntryFormProps) => {
label={t('value')}
error={formik.touched.value && Boolean(formik.errors.value)}
helperText={formik.touched.value && formik.errors.value}
slotProps={{ htmlInput: { inputMode: 'decimal' } }}
{...formik.getFieldProps('value')}
/>
{categoryQuery.isLoading
Expand Down Expand Up @@ -109,7 +110,6 @@ export const EntryForm = ({ entry, closeFn, categoryId }: EntryFormProps) => {
helperText={formik.touched.notes && formik.errors.notes}
{...formik.getFieldProps('notes')}
/>

<Stack direction="row" sx={{ justifyContent: "end", mt: 2 }}>
<Button color="primary" variant="contained" type="submit" sx={{ mt: 2 }}>
{t('submit')}
Expand Down
6 changes: 4 additions & 2 deletions src/components/Nutrition/screens/BmiCalculator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,8 @@ export const BmiCalculator = () => {
label={t('height')}
fullWidth
slotProps={{
input: { endAdornment: <Typography>{t('cm')}</Typography> }
input: { endAdornment: <Typography>{t('cm')}</Typography> },
htmlInput: { inputMode: 'decimal' }
}}
type="number"
value={height ?? ""}
Expand All @@ -113,7 +114,8 @@ export const BmiCalculator = () => {
<TextField
label={t('weight')}
slotProps={{
input: { endAdornment: <Typography>{t('server.kg')}</Typography> }
input: { endAdornment: <Typography>{t('server.kg')}</Typography> },
htmlInput: { inputMode: 'decimal' }
}}
fullWidth
type="number"
Expand Down
7 changes: 6 additions & 1 deletion src/components/Routines/widgets/forms/SessionLogsForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,9 @@ export const SessionLogsForm = ({ dayId, routineId, selectedDate }: SessionLogsF
</Typography>
: null}
</InputAdornment>

},
htmlInput: {
inputMode: 'decimal'
}
}
}}
Expand All @@ -266,6 +268,9 @@ export const SessionLogsForm = ({ dayId, routineId, selectedDate }: SessionLogsF
{formik.values.logs[index].weightUnit?.name}
</Typography>
</InputAdornment>
},
htmlInput: {
inputMode: 'decimal'
}
}
}}
Expand Down
Loading