devex: Add poll helper and refactor superadmin polls - #3560
Merged
Conversation
SuaYoo
force-pushed
the
frontend-poll-helper
branch
from
August 4, 2026 21:04
ac3ed1a to
819df12
Compare
SuaYoo
changed the title
SuaYoo
marked this pull request as ready for review
August 5, 2026 18:21
SuaYoo
force-pushed
the
frontend-poll-helper
branch
from
August 5, 2026 18:21
fbf2c26 to
3096415
Compare
emma-sg
reviewed
Aug 5, 2026
emma-sg
left a comment
emma-sg
left a comment
Member
There was a problem hiding this comment.
Feeling good overall! Left some thoughts on api shape & naming, feel free to take or leave
SuaYoo
commented
Aug 5, 2026
emma-sg
approved these changes
Aug 5, 2026
emma-sg
left a comment
emma-sg
left a comment
Member
There was a problem hiding this comment.
Pretty happy with this all in all! Left a few more musings on your last comment, but nothing blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP for #3541
Changes
PollControllerhelper to standardize polling functionality<btrix-crawls>to use poll controller<btrix-active-crawl-badge>to use poll controllerFollow-Ups
<btrix-crawls>and<btrix-active-crawl-badge>poll for essentially the same data. This PR doesn't attempt to fix that, but it should be addressed in a future PR.