Better validate various backend parameters - #3555
Merged
Merged
Conversation
emma-sg
marked this pull request as ready for review
August 1, 2026 02:31
ikreymer
approved these changes
Aug 1, 2026
ikreymer
left a comment
ikreymer
left a comment
Member
There was a problem hiding this comment.
Looks good! Thank you for adding!
The cron schedule validator is perhaps more thorough than needed, but I guess can adjust later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Implements some validations on the backend (some of which are present on the frontend) so that errors happen earlier. Primarily, crawl schedules are now properly validated! I ended up writing a little validator myself based on https://github.com/robfig/cron, the library that k8s uses.
This also better validates crawl IDs for the
/pages/reAddendpoints, and adds some constraints to thecrawlFilenameTemplateparameter as well.Testing
These changes should all be pretty well tested by the unit & integration tests added.
You can test the validation with API calls from your browser's dev tools (or curl, or whatever) with an invalid schedule to the create or update workflow endpoints.