chore(meetings): migrate meetings e2e tests to playwright by riteshfyi · Pull Request #704 · webex/widgets

riteshfyi · 2026-06-22T11:26:32Z

COMPLETES #NA

This pull request addresses

< DESCRIBE THE CONTEXT OF THE ISSUE >
We had our meetings widget e2e tests moved from wdio to playwright.

by making the following changes

1.remove wdio dependencies
2. added playwright config , dependenices
3. moved tests from wdio to playwright.

Change Type

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
Tooling change
Internal code refactor

The following scenarios were tested

The testing is done with the amplify link
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

Checklist before merging

I have not skipped any automated checks
All existing and new tests passed
I have updated the testing document
I have tested the functionality with amplify link

Make sure to have followed the contributing guidelines before submitting.

…ex#628)

The previous merge commit included generated docs/ sample build output (bundles and SVG assets). Remove them from version control; they remain on disk and are regenerated by `yarn samples:build`.

aws-amplify-us-east-2 · 2026-06-22T11:32:37Z

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-704.d1b38q61t1z947.amplifyapp.com

chatgpt-codex-connector · 2026-06-22T11:35:31Z

💡 Codex Review

widgets/playwright/meetings/pages/MeetingWidgetPage.ts

Line 36 in 32ae068

    
           this.joinMeetingBtn = this.controls.getByRole('button', { name: /^(Muted, video off|Unmuted, video on)$/ });

Locate the join button by its actual accessible name

In the widget source, focus management looks for button[aria-label="Join meeting"] (packages/@webex/widgets/src/widgets/WebexMeetings/WebexMeetings.jsx), and the architecture docs describe the muted/video text as the JoinControl hint rather than the button name. With this exact-name locator, the first joinMeetingBtn.click() in both migrated suites will time out instead of clicking Join meeting, so the new Playwright meetings e2e tests cannot get past the join step; target the Join meeting button/aria-label instead.

widgets/playwright.config.ts

Lines 94 to 96 in 32ae068

    
           const projects = testScope === 'cc' ? ccProjects 
        
             : testScope === 'meetings' ? meetingsProjects 
        
               : [...ccProjects, ...meetingsProjects];

Restrict unscoped e2e runs in the CC job

When TEST_SCOPE is unset this default now schedules both CC and meetings projects. I checked .github/workflows/pull-request.yml, and the e2e_test_cc_widgets job still runs yarn run test:e2e without setting TEST_SCOPE, so that non-continue-on-error CC job will also run the new developer.webex.com meetings setup/specs and make meetings failures block the CC e2e workflow despite the separate meetings job being best-effort. Update that workflow to test:e2e:cc or keep the unscoped default from adding meetings there.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

This changelog source file was inadvertently removed in the docs build artifact cleanup. It is a real source file and belongs in version control.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5fb20e33f5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-06-22T11:45:55Z

+const projects = testScope === 'cc' ? ccProjects
+  : testScope === 'meetings' ? meetingsProjects
+    : [...ccProjects, ...meetingsProjects];


Scope unqualified e2e runs to one setup

When yarn run test:e2e is used (the cc widgets workflow still does this in .github/workflows/pull-request.yml), this default branch schedules both the CC OAuth setup and the new meetings setup together. Both setup files read/modify/write the same root .env without any dependency between them, so under the existing parallel Playwright run the last writer can drop the other setup's generated tokens and leave either CC or meeting tests without credentials; use the scoped script in the workflow or serialize/merge the setup writes.

Useful? React with 👍 / 👎.

this is addressed in the workflow update pr

chatgpt-codex-connector · 2026-06-22T11:45:55Z

+    this.unmuteAudioBtn = this.controls.getByRole('button', { name: 'Unmute' });
+    this.muteVideoBtn = this.controls.getByRole('button', { name: 'Stop video' });
+    this.unmuteVideoBtn = this.controls.getByRole('button', { name: 'Start video' });
+    this.joinMeetingBtn = this.controls.getByRole('button', { name: /^(Muted, video off|Unmuted, video on)$/ });


Target the actual Join meeting button

When the migrated suite reaches the join step, this locator only matches buttons named with the muted/unmuted state, but the widget's pre-join control is still exposed and queried as aria-label="Join meeting" in packages/@webex/widgets/src/widgets/WebexMeetings/WebexMeetings.jsx, and the removed WDIO page clicked the visible Join meeting control. In that state Playwright will not find/click the join button, so the tests time out before verifying the in-meeting UI.

Useful? React with 👍 / 👎.

riteshfyi · 2026-06-25T07:43:48Z

Proof in CI : https://github.com/riteshfyi/widgets/actions/runs/28152084721/job/83372762053

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2a79a00fdb

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-06-29T11:54:26Z

-    needs: [install, build]
+    env:
+      DOTENV_CONFIG_QUIET: true
+\    needs: [install, build]


Remove the stray backslash before needs

In the pull-request workflow, this leading backslash makes the YAML invalid before GitHub Actions can schedule any jobs; parsing this file now fails at the e2e_test_cc_widgets block, so the PR workflow cannot run at all until needs is restored as a normal job key.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-06-29T11:54:26Z

@@ -11989,22 +11401,15 @@ __metadata:
    "@momentum-ui/core": "npm:19.16.0"
    "@momentum-ui/icons": "npm:8.28.5"
    "@momentum-ui/react": "npm:^23.21.4"
+    "@playwright/test": "npm:^1.51.1"


Keep the widget lock entry in sync

This added workspace lock entry says @webex/widgets depends on @playwright/test, but the package manifest no longer declares that dependency; with the repository's Yarn 4 install in CI, immutable installs abort when the lockfile would be modified, so the install job will fail until the dependency is either added to packages/@webex/widgets/package.json or removed by regenerating the lockfile.

Useful? React with 👍 / 👎.

yarn itsefl didn't pick this, i have updated the file

riteshfyi · 2026-06-29T13:39:42Z

    timeout-minutes: 50
    runs-on: ubuntu-latest
+    env:
+      DOTENV_CONFIG_QUIET: true


the latest versions of dotenv, have promotions added in logs, so to remove those logs, this flag is set

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 08a1d1491e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-06-29T13:45:10Z

+  await page.getByRole('textbox', { name: /^Welcome / }).waitFor({ state: 'visible', timeout: 30000 });
+  await page.getByRole('textbox', { name: /^Welcome / }).fill(process.env.PW_MEETING_PASSWORD);
+  await page.getByRole('button', { name: 'Sign In' }).click();
+  await page.waitForURL(DEVELOPER_WEBEX_URL);


Use a non-exact wait after Webex login

When the developer portal redirects back to its canonical https://developer.webex.com/ URL, this wait does not match because DEVELOPER_WEBEX_URL lacks the trailing slash and Playwright treats strings without wildcards as exact URL matches (docs). The setup project then times out before writing PW_MEETING_ACCESS_TOKEN, so meeting E2E runs fail immediately after login; include the canonical slash or use a glob/regex here.

Useful? React with 👍 / 👎.

nah, this works properly, verifed

there is a 10 min timeout in the job itself, so not worries for that

riteshfyi and others added 2 commits March 10, 2026 12:33

fix(tooling): remove wdio & upgrade meeting widget to playwright (web…

28fc765

…ex#628)

fix: pull changes

32ae068

riteshfyi requested a review from a team as a code owner June 22, 2026 11:26

chore: remove accidentally committed docs build artifacts

570e80d

The previous merge commit included generated docs/ sample build output (bundles and SVG assets). Remove them from version control; they remain on disk and are regenerated by `yarn samples:build`.

chore: restore docs/changelog comparison-view.js

5fb20e3

This changelog source file was inadvertently removed in the docs build artifact cleanup. It is a real source file and belongs in version control.

riteshfyi added validated Indicates that the PR is ready for actions run_e2e Add this label to run E2E test for meeting and CC widgets labels Jun 22, 2026

chatgpt-codex-connector Bot reviewed Jun 22, 2026

View reviewed changes

riteshfyi changed the title ~~tooling: migrate meetings e2e tests to playwright~~ chore(meetings): migrate meetings e2e tests to playwright Jun 22, 2026

riteshfyi changed the title ~~chore(meetings): migrate meetings e2e tests to playwright~~ fix(meetings): migrate meetings e2e tests to playwright Jun 22, 2026

riteshfyi added run_e2e Add this label to run E2E test for meeting and CC widgets and removed run_e2e Add this label to run E2E test for meeting and CC widgets labels Jun 22, 2026

riteshfyi changed the title ~~fix(meetings): migrate meetings e2e tests to playwright~~ tooling(meetings): migrate meetings e2e tests to playwright Jun 23, 2026

riteshfyi changed the title ~~tooling(meetings): migrate meetings e2e tests to playwright~~ feat(meetings): migrate meetings e2e tests to playwright Jun 29, 2026

riteshfyi changed the title ~~feat(meetings): migrate meetings e2e tests to playwright~~ choremeetings): migrate meetings e2e tests to playwright Jun 29, 2026

riteshfyi changed the title ~~choremeetings): migrate meetings e2e tests to playwright~~ chore(meetings): migrate meetings e2e tests to playwright Jun 29, 2026

riteshfyi added validated Indicates that the PR is ready for actions and removed validated Indicates that the PR is ready for actions labels Jun 29, 2026

eigengravy approved these changes Jun 29, 2026

View reviewed changes

clean up stuff

2a79a00

github-actions Bot removed the validated Indicates that the PR is ready for actions label Jun 29, 2026

chatgpt-codex-connector Bot reviewed Jun 29, 2026

View reviewed changes

riteshfyi added 2 commits June 29, 2026 19:04

update yarn lock again

0204d60

space remover

08a1d14

riteshfyi commented Jun 29, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Jun 29, 2026

View reviewed changes

Uh oh!

Conversation

riteshfyi commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

COMPLETES #NA

This pull request addresses

by making the following changes

Change Type

The following scenarios were tested

The GAI Coding Policy And Copyright Annotation Best Practices

Checklist before merging

Uh oh!

aws-amplify-us-east-2 Bot commented Jun 22, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 22, 2026

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 22, 2026

Choose a reason for hiding this comment

Uh oh!

riteshfyi Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jun 22, 2026

Choose a reason for hiding this comment

Uh oh!

riteshfyi commented Jun 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

riteshfyi Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

riteshfyi Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

riteshfyi Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

riteshfyi Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

riteshfyi Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

riteshfyi commented Jun 22, 2026 •

edited

Loading

riteshfyi Jun 29, 2026 •

edited

Loading