ci: skip winget update during the first-submission window - #23
Merged
Conversation
The update-winget job runs komac update, which needs a merged base manifest as its template and must not open a second "New package" PR while the first WebCodr.jwtd submission is still under moderation. Add a guard step that checks whether the package already exists in winget-pkgs main and gates the komac install/submit steps on it, so a release cut during the first-submission window skips WinGet cleanly (a GitHub Actions notice) instead of failing the job or opening a duplicate new-package PR. Normal automation resumes on its own once the first PR merges. Every other release channel is an independent job, so this never affects them. TestWinGetInvariants now asserts the existence check and that the komac install/submit steps are gated on its output. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a guard to the
update-wingetjob so a release cut while the firstWebCodr.jwtdsubmission is still under moderation is handled cleanly.Why
komac updateneeds a merged base manifest as its template.WebCodr.jwtdis not yet inwinget-pkgsmain — the first submission (PR microsoft/winget-pkgs#407788, "New package … 5.2.0") is still in moderation. Cutting another release now would make komac either fail or open a second "New package" PR competing with the first.What
A new first step queries whether the package exists in winget-pkgs main:
The download/verify/install-komac/submit steps are gated on
steps.pkg.outputs.exists == 'true'. So during the first-submission window the job skips cleanly (emits a GHA notice) instead of failing or opening a duplicate PR; once the first PR merges and the package is in main, the guard passes and normal automation resumes with no further changes.This changes nothing for the other channels — Homebrew/Scoop/AUR/COPR/release are independent jobs (
needs: [validate, release]), unaffected either way.Tests
TestWinGetInvariantsnow asserts the existence-check step exists and that the komac install/submit steps are gated on its output. Full suite + workflow security invariants pass. (The guard comment deliberately avoids the word the step-finder greps for, so the existing komac-step lookups stay unambiguous.)🤖 Generated with Claude Code