fix: EventLog handle leak and StreamWriter crash in WinBGP CLI#7
Open
Daymarvi wants to merge 1 commit into
Open
fix: EventLog handle leak and StreamWriter crash in WinBGP CLI#7Daymarvi wants to merge 1 commit into
Daymarvi wants to merge 1 commit into
Conversation
- Fix EventLog handle leak: Dispose() EventLog objects in Write-Log when using AdditionalFields (prevents handle exhaustion in 24/7 service) - Fix StreamWriter on unconnected pipe: create StreamWriter after pipe.Connect() to avoid Dispose() crash when service is not running
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix two resource management issues in
WinBGP.ps1(CLI):1. EventLog handle leak in Write-Log
[System.Diagnostics.EventLog]::new()implementsIDisposablebut was never disposed after writing events withAdditionalFields. In a 24/7 service context, this causes gradual handle exhaustion.Fix: Wrap EventLog usage in
try/finallywithDispose().2. StreamWriter crash on unconnected pipe in Send-PipeMessage
StreamWriterwas created beforepipe.Connect(). If the connection failed or timed out,Dispose()on theStreamWriterwould throw an unhandled .NET exception because the underlying pipe was never connected.Fix: Move
StreamWritercreation after successfulpipe.Connect(1000).Testing
Tested on production server
my.server.net.Functional tests
WinBGP.ps1 -StatusRunningWinBGP.ps1 -BGPStatusupWinBGP.ps1 -RouteName my.server.net -StartMaintenanceSuccessWinBGP.ps1 -RouteName my.server.net -StopMaintenanceSuccessWinBGP.ps1 -RouteName my.server.net -StopRouteSuccessWinBGP.ps1 -RouteName my.server.net -StartRouteSuccessHandle leak test
-StatuscallsRunning